Add nodata/fill-value handling to ndvi, ndwi, evi - #10
Open
ysims wants to merge 1 commit into
Open
Conversation
Add an optional nodata kwarg to each index function so numeric fill sentinels (e.g. -9999) are treated as missing the same way literal None values already are. When not passed explicitly, nodata is resolved from scene.metadata["nodata"], supporting either a single global sentinel or a dict[band_name, value] per-band mapping. Implementation masks sentinel-matching pixels to None before handing off to the existing _map_binary/_map_ternary helpers, so the None-is-missing logic is reused rather than duplicated. Matching is exact equality by design (documented in each docstring), which is the predictable choice for typical integer-style sentinels. Fully additive: with no nodata kwarg and no scene.metadata["nodata"], behaviour is unchanged from before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional nodata kwarg to each index function so numeric fill sentinels (e.g. -9999) are treated as missing the same way literal None values already are. When not passed explicitly, nodata is resolved from scene.metadata["nodata"], supporting either a single global sentinel or a dict[band_name, value] per-band mapping.
Implementation masks sentinel-matching pixels to None before handing off to the existing _map_binary/_map_ternary helpers, so the None-is-missing logic is reused rather than duplicated. Matching is exact equality by design (documented in each docstring), which is the predictable choice for typical integer-style sentinels. Fully additive: with no nodata kwarg and no scene.metadata["nodata"], behaviour is unchanged from before.