IFA Updates - #52
Merged
Merged
IFA Updates#52
Conversation
Why? We need more actions and varying action menus per-state. Base actions menu code taken from https://github.com/icefoganalytics/wrap/blob/3abe4c91eaf2206578446090dec42ba2dec91ecd/web/src/components/common/BaseActionsMenuBtnGroup.vue
TODO: need to add dedicated back-end endpoint for creation ArchiveItem from ISA namespace.
Groups of items should be plural to denote that they are a group rather than a singular thing.
TODO: Add files and categoryIds to archive item creation.
Should use standardized nesting patterns for nested resources.
i.e.
{ filesAttributes } (if "files" associations on model)
Pattern taken from Rails-verse. Need to implement in back-end.
Why? Help reduce coupling and make it clear that this "integration" interacts with an external entity (Azure Blob Storage).
Why? So we can keep front- and back-end version in sync. (and hopefully process "true" and "false" as booleans correctly)
Files require form-data format.
Always return an object, since this reduces the number of null and type checks we need.
…e objects. Now uses Lodash to do the same thing.
Page level params will always be "string", but and then should be converted to "number".
Why? To hopefully let me use longer identifiers, so I don't have to rename a bunch of stuff.
informationSharingAgreementAccessGrants -> accessGrants. Why? To fix this Sequelize query error: The identifier that starts with 'informationSharingAgreementAccessGrants.ArchiveItemInformationSharingAgreementAccessGrant.informationSharingAgreementAccessGrant' is too long. Maximum length is 128. I'm probably going to need to rename InformationSharingAgreement to SharingAgreement at some point.
Why? So we can correctly serialize the policy. Note, this isn't a great fix, since the policy archiveItem is stale when serialized.
Also add archive item file destroy service.
You can't (and don't need to) delete entires from database "views". Instead delete the data that feeds them.
Why? Easier to understand relationship.
How? Instead of relying on complex cascading services, we now do everything directly. This reduces complexity, at the cost of future code maybe going out of sync between services.
Why? Better experience.
Instead log only when job is doing something.
Otherwise show Create Knowledge Item link.
NOTE: this restriction is UI only.
Make primary button dynamic based on whether knowledge item exists. Remove "edit" call-to-action now that you can no longer edit signed agreements. "revert to draft" is still present in the extended actions menu.
…-fields-from-isa-when-creating-knowledge-item TK-28: Auto-fill Mandatory Fields from ISA When Creating Knowledge Item
datajohnson
pushed a commit
that referenced
this pull request
Aug 28, 2026
TK-84: Use ISA Numbers in Knowledge Item Links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation for agent workflows and planning in the Traditional Knowledge project. The main improvements are the addition of new comprehensive workflows for code review and testing instructions, consolidation and renaming of the Jira issue workflow, and restructuring of documentation for clarity and consistency. The changes ensure that multi-step guides for PR creation, code review, and issue management are clearly documented and easy to follow.
Workflow Documentation Improvements
code-review.mdworkflow detailing strict code review standards for TypeScript code, including step-by-step rules and output format. This is now step 2 in the complete PR creation sequence.testing-instructions.mdworkflow for generating comprehensive testing instructions for pull requests. [1] [2] [3] [4]Jira Workflow Consolidation
jira-issue-creation.mdwithjira-issue-management.mdto cover creation, enhancement, and management of Jira issues. References and links throughout documentation have been updated for consistency. [1] [2] [3] [4] [5]Documentation Structure and Usability
agents/workflows/README.mdto use a tabular format for available workflows and provide a clear step-by-step PR creation sequence, referencing new and updated workflows.Planning Documentation Updates
agents/plans/README.mdby removing the explicit plan table and clarifying naming conventions for plan files. Updated the last modified date. [1] [2]Removed Deprecated Content
jira-issue-creation.mdworkflow, consolidating its content into the newjira-issue-management.md.These updates make the workflow documentation more comprehensive, easier to navigate, and better aligned with current project practices.