Jul22 - #56
Merged
Merged
Jul22#56
Conversation
Use negative PID to kill entire process group instead of just parent process. Ensures bridge can be properly shut down when spawned with pgroup: true.
…tes/information-sharing-agreements/confidentiality-acknowledgement-template.docx` was not being populated by `api/src/serializers/information-sharing-agreements/generate-confidentiality-acknowledgement/create-serializer.ts`
…defined-at-access-from-isa Populate key `access_level_department_restriction` in CA template
…er-takes-you-to-internal-user-edit-screen External User Edit form for external users
…from-admin-portal-doesnt-match-sharing-agreement-isa-screen Tk 63: Removing admin ISA create and edit pages
…ngviewing-knowledge-item-from-isa Tk 80: Simplifying ISA archive item create process
Fix stale migration, template, and workflow links so the shared strict guidance audit passes.
…leanup Repair Traditional Knowledge Guidance Links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and cleanups across the backend and frontend, with a focus on simplifying archive item creation, updating documentation, and correcting navigation and references. The most significant changes are the refactoring of the archive item creation service to remove category assignment logic, the addition of new fields to serializers, and updates to documentation and navigation routes.
Backend Changes
Archive Item Creation Refactor:
ArchiveItemcreation increate-service.tsto remove category assignment logic and related types, and to derive thesecurityLevelfrom theaccessLevelof the associated information sharing agreement. Also, added logic to resolve Yukon First Nations from the external group contact. [1] [2] [3] [4] [5]Serializer Enhancements:
access_level_department_restrictionfield to both theInformationSharingAgreementAsConfidentialityAcknowledgementtype and the serializer output increate-serializer.ts. [1] [2]Frontend Changes
API and Component Cleanup:
archive-items-api.tsby removing unused fields and types related to archive item categories and other attributes that are no longer required. (F7b4c248L1)Navigation and Routing Fixes:
users/UserInternalEditPagefor consistency. [1] [2]Component Removal:
ArchiveItemNewButton.vueandInformationSharingAgreementAdminCreateForm.vuecomponents to clean up the codebase. [1] [2]Documentation and Reference Corrections
Documentation Updates:
README.mdfiles. [1] [2] [3]These changes streamline archive item creation, improve code maintainability, and ensure documentation and navigation are accurate and up-to-date.