Aug 8 - #61
Merged
Merged
Aug 8#61
Conversation
…layout-for-sharing-agreement-users-groups TK-64: Improve Breadcrumb layout for Sharing Agreement, Users, Groups
VDataIterator only gained support for the items-length prop (manual/server-side pagination) in 3.12.0. On the previously installed 3.11.8, it silently ignored items-length and computed page count from the current page's item count instead of the total, so the notifications list never showed more than one page. package.json's existing ^3.11.8 range already permitted this version.
Pairs with the existing useRouteQueryPagination composable; wires a v-pagination control to a page/perPage model and computes total pages from a totalCount prop.
…ions-page-doesnt-seem-to-work TK-88: Paging in notifications page doesnt seem to work
Use the ISA number for the canonical knowledge item list and association detail URLs, preserving many-to-many links without selecting an arbitrary first item.
Rename the knowledge item list/detail route path segment from archive-items to knowledge-items so URLs no longer reference the old archive terminology (TK-84).
Both new pages jumped straight from the ISA list to the current page, skipping the specific agreement, so there was no way back to it via the breadcrumb trail. Add the missing ISA crumb, matching the pattern used on InformationSharingAgreementAccessGrantsPage.
An ISA has at most one knowledge item, so route "View Knowledge Item" directly to InformationSharingAgreementKnowledgeItemPage instead of the plural list page.
Nothing links to InformationSharingAgreementKnowledgeItemsPage now that the signed actions menu goes straight to the single knowledge item page. Drop the page, its route, and the list item component it was the only user of.
Mirror ArchiveItemPage's structure: an Information Sharing Agreements tab and a Users with Access tab, each backed by their own copy of the archive-items versions since this page only has the ISA<->knowledge item association id (not the raw archiveItemId) in its URL. Add a small composable to resolve that association once per page and validate it belongs to the ISA in the URL, same check the page already did.
TK-84: Use ISA Numbers in Knowledge Item Links
…d external organization. A missing external organization on the ISA's external group contact is a state the UI already tolerates elsewhere (shown as "Not specified"), but archive-item creation treated it as fatal, throwing an error that the frontend surfaced only as a generic "Save failed" message. Resolve yukonFirstNations to an empty list instead of failing the whole request. Undoes the throw added in 3309466. See TK-82.
…owledge-items-from-isa TK-82: Unable to create Knowledge items from ISA
The attachments card was a read-only viewer and the API only supported downloading files, so there was no way to add a file after a Knowledge Item was created. Adds a POST /api/archive-items/:archiveItemId/files endpoint (reusing the existing ArchiveItemFiles create service) and an upload control in the attachments card, gated by the item's update policy. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…und. A global rule in yk-style.css sets div/p text color app-wide, which directly targets the divs/paragraphs Vuetify renders for v-card-title and v-card-text and wins over anything the ancestor card's color prop sets, since a rule matching an element directly always beats a value merely inherited from a parent. Overrides it here, scoped to this card, to use the theme's on-secondary color instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…les-in-knowledge-items TK-81: Unable to attach files in knowledge items
…les-in-knowledge-items TK-81: Follow up (missing commit)
datajohnson
pushed a commit
that referenced
this pull request
Sep 8, 2026
…y-matrix---admins TK-24: User access Security Matrix - Admins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several backend and documentation improvements related to archive item file management, information sharing agreement (ISA) associations, and model behavior. The most significant changes include the addition of an API endpoint for uploading files to archive items, improved handling of external organization associations in the archive item creation service, and enhanced test coverage for these scenarios. It also adds documentation clarifying the navigation and model naming for ISAs and knowledge items.
API and Controller Enhancements:
POST /api/archive-items/:archiveItemId/filesendpoint inArchiveItemFilesControllerto allow authorized users to attach files to an archive item, with validation and auditing of uploads. [1] [2]loadArchiveItemto include relatedaccessGrantsdata when fetching an archive item, improving authorization and access control.Service Logic Improvements:
CreateService) so that if an external group contact lacks an associated external organization, the archive item is still created but without theyukonFirstNationsfield set, rather than throwing an error.Testing:
Documentation:
README.mdto clarify the navigation and association logic between ISAs and knowledge items, and documented the transition in route naming conventions.These changes improve the robustness, usability, and maintainability of archive item and ISA-related features.