Kellett - refs #1084: campaign page social media icons do not appear correctly - #1097
Merged
willsstrong merged 2 commits intoJun 26, 2026
Conversation
… CSS URLs This removes the JS SVG swap method and just uses direct webfonts to bypass CloudFlare's Rocket Loader.
This removes a redundant load of the local FA4 font and css, which had only been used for the thumbs up/down icons in the feedback form, but is otherwise not needed. The footer SCSS has been updated for FA6 now, so will work with the module-only loading of FA6.
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Included
Refs #1084
Deployment Steps
drush cimNote
This still uses the FontAwesome CDN, as the site did previously — it now loads CSS instead of JS, so it's unaffected by Rocket Loader. If you'd prefer the library hosted locally instead, that can be set up as a composer-managed library before merge — just let me know.