Skip to content

docs(req-011): re-verify test coverage still matches current acceptance criteria - #176

Merged
ytnobody merged 1 commit into
developfrom
hermit/ytnobody/issue-174
Jul 24, 2026
Merged

docs(req-011): re-verify test coverage still matches current acceptance criteria#176
ytnobody merged 1 commit into
developfrom
hermit/ytnobody/issue-174

Conversation

@ytnobody

Copy link
Copy Markdown
Owner

Summary

Issue #174 was auto-filed because the requirements-reconcile sweep detected REQ-011's requirement text had changed in REQUIREMENTS.md, and asked whether the corresponding test still validates the current acceptance criteria.

Investigation

  • REQ-011's acceptance-criteria text (get_config returns max_engineers; the CLAUDE.md template references it as the parallel-Engineer cap) has not changed since it was written — only the 実装状況 prose note changed, in PR test(req-011): add coverage for CLAUDE.md template's max_engineers cap #167 (commit c278115), which in the very same commit added the two tests that close the gap:
    • internal/mcp/req_test.go::TestREQ011_GetConfig_ReturnsMaxEngineers
    • cmd/hermit/inprocess_test.go::TestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCap
  • Re-checked both tests against the template as it stands today, after PR fix(superintendent): run cycle inline instead of spawning a background subagent per cron tick #172 merged the previously separate "Foreground dispatch" / "Background cycle" sections of the Superintendent role into a single "Superintendent cycle": the exact substrings the template test asserts on (up to N at a time, exceeds N, max_engineers = N) are still present verbatim in cmd/hermit/templates/CLAUDE.md.tmpl, rendered with a distinctive non-default value (9) to rule out false passes against the hardcoded default.
  • Conclusion: both tests still correctly and fully verify the current REQ-011 acceptance criteria. No test logic changes were needed.

Changes in this PR

No production code changes — this is a documentation/traceability-only PR confirming existing coverage remains correct.

Test plan

  • go build ./...
  • go vet ./...
  • gofmt -l . (no output)
  • go test ./... (all packages pass, including TestREQ011_GetConfig_ReturnsMaxEngineers and TestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCap individually)

Closes #174

🤖 Generated with Claude Code

…ce criteria

Closes #174

Investigated after the requirements-reconcile sweep flagged REQ-011's
requirement text as changed. The actual acceptance-criteria wording
(get_config returns max_engineers; CLAUDE.md template references it as
the parallel-Engineer cap) hasn't changed since it was introduced; only
the 実装状況 note was updated in PR #167, in the same commit that added
TestREQ011_GetConfig_ReturnsMaxEngineers (internal/mcp/req_test.go) and
TestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCap
(cmd/hermit/inprocess_test.go).

Re-checked both tests against the current template after PR #172
merged the Superintendent cycle's separate "Foreground dispatch" /
"Background cycle" sections into one "Superintendent cycle": the
substrings the tests assert on ("up to N at a time", "exceeds N",
"max_engineers = N") are still present verbatim, so both tests still
correctly verify the current acceptance criteria — no test logic
changes were needed. Added a doc-comment note and a REQUIREMENTS.md
implementation-note addendum recording this re-verification for future
sweeps.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@ytnobody
ytnobody merged commit 05baf02 into develop Jul 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REQ-011: requirement text changed — review its test

1 participant