docs(req-011): re-verify test coverage still matches current acceptance criteria - #176
Merged
Conversation
…ce criteria Closes #174 Investigated after the requirements-reconcile sweep flagged REQ-011's requirement text as changed. The actual acceptance-criteria wording (get_config returns max_engineers; CLAUDE.md template references it as the parallel-Engineer cap) hasn't changed since it was introduced; only the 実装状況 note was updated in PR #167, in the same commit that added TestREQ011_GetConfig_ReturnsMaxEngineers (internal/mcp/req_test.go) and TestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCap (cmd/hermit/inprocess_test.go). Re-checked both tests against the current template after PR #172 merged the Superintendent cycle's separate "Foreground dispatch" / "Background cycle" sections into one "Superintendent cycle": the substrings the tests assert on ("up to N at a time", "exceeds N", "max_engineers = N") are still present verbatim, so both tests still correctly verify the current acceptance criteria — no test logic changes were needed. Added a doc-comment note and a REQUIREMENTS.md implementation-note addendum recording this re-verification for future sweeps. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #174 was auto-filed because the requirements-reconcile sweep detected REQ-011's requirement text had changed in REQUIREMENTS.md, and asked whether the corresponding test still validates the current acceptance criteria.
Investigation
get_configreturnsmax_engineers; the CLAUDE.md template references it as the parallel-Engineer cap) has not changed since it was written — only the実装状況prose note changed, in PR test(req-011): add coverage for CLAUDE.md template's max_engineers cap #167 (commit c278115), which in the very same commit added the two tests that close the gap:internal/mcp/req_test.go::TestREQ011_GetConfig_ReturnsMaxEngineerscmd/hermit/inprocess_test.go::TestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCapup to N at a time,exceeds N,max_engineers = N) are still present verbatim incmd/hermit/templates/CLAUDE.md.tmpl, rendered with a distinctive non-default value (9) to rule out false passes against the hardcoded default.Changes in this PR
REQUIREMENTS.md: added a short addendum to REQ-011's実装状況note recording this re-verification (so a future sweep diff on this line doesn't re-trigger the same investigation without context).cmd/hermit/inprocess_test.go: added a doc-comment note onTestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCaprecording the same re-verification against the post-fix(superintendent): run cycle inline instead of spawning a background subagent per cron tick #172 template.No production code changes — this is a documentation/traceability-only PR confirming existing coverage remains correct.
Test plan
go build ./...go vet ./...gofmt -l .(no output)go test ./...(all packages pass, includingTestREQ011_GetConfig_ReturnsMaxEngineersandTestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCapindividually)Closes #174
🤖 Generated with Claude Code