docs(req-011): re-verify test coverage still matches current acceptance criteria - #184
Merged
Conversation
…ce criteria (#183) REQ-011's acceptance-criteria text is unchanged from the previous re-verification (Issue #174); re-ran TestREQ011_GetConfig_ReturnsMaxEngineers and TestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCap and confirmed both still pass and correctly cover the acceptance criteria as written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #183.
REQ-011 の要件テキストが変更されたとして起票されたレビュー Issue。実際に REQUIREMENTS.md の受け入れ条件文言 (
get_configが harness.toml の max_engineers 値を返し、CLAUDE.md テンプレートが並列上限としてこの値を参照していること) を確認したところ、Issue #174 での前回再点検時から実質的な変更はなかった。対応するテストを再実行して確認:
internal/mcp/req_test.goのTestREQ011_GetConfig_ReturnsMaxEngineerscmd/hermit/inprocess_test.goのTestREQ011_ClaudeMdReferencesConfiguredMaxEngineersAsCapいずれも green で、現行の受け入れ条件を引き続き正しく検証していることを確認した。テストコード自体の修正は不要と判断し、REQUIREMENTS.md の実装状況欄に短い再点検コメントを追記するのみに留めた。
仮定・注記
本 Issue は Issue #182 (「review-test の自己増殖バグ」: 実装状況欄への追記が要件ブロックのハッシュを変え、次回 sweep で再び review-test Issue を起票してしまう) の症状の一つである可能性がある。#182 のハッシュ計算方式自体の修正は別 Issue/別担当のスコープのため、本 PR では手を加えていない。
Test plan
go test ./internal/mcp/... -run TestREQ011 -v— PASSgo test ./cmd/hermit/... -run TestREQ011 -v— PASS🤖 Generated with Claude Code