Querying `/node/stats?format=json` does not properly serialize the node stats

[ctrowat]

When making a GET request to the specified endpoint node stats are not returned correctly. Instead I get a response like this:

{
    "DEVICE1": "#<Oxidized::Node::Stats:0x000055fbadc63230>",
    "DEVICE2": "#<Oxidized::Node::Stats:0x000055fbadc31168>",
    "DEVICE3": "#<Oxidized::Node::Stats:0x000055fbadb44110>",
    "DEVICE4": "#<Oxidized::Node::Stats:0x000055fbadc2a750>",
...
}

[fernandolcx]

same here

[robertcheramy]

I can reproduce. ?format=text also not working.

[danwalkeruk]

Confirmed here, I made an issue on the other repo ytti/oxidized#3234, and it has been mentioned here before #182

I have zero Ruby knowledge, but from some brief poking and GPT-ing, it seems to be that within lib/oxidized/web/webapp.rb there needs to be a serialisation method for the Node::Stats class, as currently when it's converted to json, you just get the above.

Anyone with Ruby knowledge able to take a look? Doesn't seem a big fix for this one.

[github-actions]

This issue is stale because it has been open 90 days with no activity.

[robertcheramy]

Note: not a very easy fix as the logic is implemented in

oxidized-web/lib/oxidized/web/views/stats.haml

Lines 30 to 83 in 785ccef

	%tbody
	- @data.map do |node, stats|
	- status = 'no_connection'
	- successes = stats.successes
	- failures = stats.failures
	- avg_success_time = 0
	- avg_failure_time = 0
	- avg_time = 0
	- row_class = ''
	- if success = stats.get(:success)
	- last_success = success.last[:end]
	- avg_success_time = success.collect {|x| x[:time]}
	- avg_success_time = avg_success_time.inject {|sum, x| sum + x}
	- avg_success_time /= successes
	- if no_connection = stats.get(:no_connection)
	- last_failure = no_connection.last[:end]
	- avg_failure_time = no_connection.collect {|x| x[:time]}
	- avg_failure_time = avg_failure_time.inject {|sum, x| sum + x}
	- avg_failure_time /= failures
	- if avg_success_time > 0 && avg_failure_time > 0
	- avg_time = (avg_success_time + avg_failure_time) / 2
	- elsif avg_success_time > 0
	- avg_time = avg_success_time
	- elsif avg_failure_time > 0
	- avg_time = avg_failure_time
	- avg_time = "#{'%.2f' % avg_time}" unless avg_time == 'Unknown'
	- if last_success && last_failure
	- status = last_success > last_failure ? 'success' : 'no_connection'
	- elsif last_success
	- status = 'success'
	- last_failure = 'never'
	- else
	- last_success = 'never'
	- total_runs = successes + failures
	- failure_rate = (failures / total_runs.to_f) * 100
	- row_class = 'warning' if failure_rate >= 50
	- row_class = 'danger' if failure_rate >= 75
	%tr{class: row_class}
	%td= node
	%td= total_runs
	%td= failures
	%td #{'%.2f' % failure_rate}%
	%td #{'%.2f' % avg_time}
	%td
	%div{title: status, class: status}
	%span{style: 'visibility: hidden'}#{status}
	%td.time= last_success
	%td.time= last_failure

and needs to be move to oxidized, while keeping reverse compatibility for one version.

[github-actions]

This issue is stale because it has been open 90 days with no activity.