feat: add dispose_chart method for Echarts and Leptos integration#217
Open
MingleHeart wants to merge 2 commits into
Open
feat: add dispose_chart method for Echarts and Leptos integration#217MingleHeart wants to merge 2 commits into
MingleHeart wants to merge 2 commits into
Conversation
PanagiotisS
added a commit
to PanagiotisS/charming
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source of the issue
Within the Leptos framework, encapsulating Chart-related components and using Custom::renderItem may cause the reused component to display residual custom content from the previous instance.
Solution
This pull request adds support for properly disposing of chart instances in the
WasmRenderer, which is especially useful for freeing up resources in dynamic web applications, such as those built with Leptos. The main changes include introducing adispose_chartmethod, exposing the underlyingdisposemethod of theEchartstype to Rust, and ensuring thread safety forEchartsby implementingSyncandSend.New chart disposal support:
dispose_chartmethod toWasmRenderer, allowing users to explicitly dispose of chart instances and providing detailed documentation and usage examples, including integration with Leptos'son_cleanuplifecycle.WebAssembly interop and thread safety:
disposemethod of the JavaScriptEchartsobject to Rust viawasm_bindgen, enabling the actual disposal logic to be called from Rust code.SyncandSendfor theEchartstype, making it possible to safely shareEchartsinstances across threads, which is important for concurrent or async Rust web applications.