Fix: Support deserialising additional valid chart options #222
Open
Johnabell wants to merge 3 commits into
Open
Fix: Support deserialising additional valid chart options #222Johnabell wants to merge 3 commits into
Johnabell wants to merge 3 commits into
Conversation
Johnabell
changed the title
Johnabell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was tying to use charming for the type definitions but discovered that it was unable to deserialise some valid chart options.
I have therefore updated the deserialisation to support this. There is an additional test with a valid chart options json that used to fail to decode.
I also fixed a couple of warnings I saw when using
--no-default-featuresand a couple of typos.