Skip to content

feat(holdings): surface portfolio summary as KPIs #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yubnsbski merged 1 commit into from
Jun 25, 2026
Merged

feat(holdings): surface portfolio summary as KPIs #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions web/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2838,6 +2838,9 @@ function PieChart({ slices }: { slices: { label: string; value: number }[] }) {

function AnalysisResult({ data }: { data: Json }) {
const rows = Array.isArray(data.holdings) ? data.holdings : [];
const summary = asJson(data.summary) ?? {};
const largest = asJson(summary.largest_position);
const pnlPositive = (Number(summary.unrealized_pnl) || 0) >= 0;
const slices = rows
.map((row) => ({
label: String(row.name || row.ticker_or_fund_code || "?"),
Expand All @@ -2846,6 +2849,29 @@ function AnalysisResult({ data }: { data: Json }) {
.filter((s) => s.value > 0);
return (
<ResultBlock title="分析結果" meta={`評価額: ${yen(data.summary?.market_value)}`}>
{Object.keys(summary).length > 0 && (
<section className="detail-section">
<h4>サマリー</h4>
<div className="detail-metrics">
<DetailFact label="評価額" value={yen(summary.market_value)} />
<DetailFact label="取得額" value={yen(summary.cost_basis)} />
<DetailFact
label="評価損益"
value={yen(summary.unrealized_pnl)}
tone={pnlPositive ? "safe" : undefined}
/>
<DetailFact label="損益率" value={percent(summary.unrealized_pnl_pct)} />
<DetailFact label="年間配当見込み" value={yen(summary.annual_income_estimate)} />

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Show zero yen values in the dividend KPI

When a portfolio has no dividend/distribution estimate, the backend returns annual_income_estimate: 0, but yen() renders numeric zero as -. Since this new summary row is meant to surface KPIs, no-income portfolios now look like the income value is unavailable rather than actually 0円; use the zero-preserving formatter for this KPI.

Useful? React with 👍 / 👎.

<DetailFact label="収入利回り" value={percent(summary.income_yield_pct)} />
{largest && (
<DetailFact
label="最大保有"
value={`${String(largest.name ?? largest.code ?? "-")}（${percent(largest.share_pct)}）`}
/>
)}
</div>
</section>
)}
{slices.length > 0 && (
<>
<h4>ポートフォリオ構成比（評価額）</h4>
Expand Down
Loading