fix: regenerate Android Gradle scaffolding for runnable template (fixes #13) - #17
Merged
Conversation
…plate Add the standard Flutter Android platform scaffolding (manifest, gradle files, wrapper, resources) via flutter create --platforms=android. - minSdk = 23 for flutter_secure_storage 9.x (docs/setup_reference.md) - applicationId com.example.flutter_template derives from pubspec name - upgrade sentry_flutter 8.14.2 -> 9.27.0: required so the generated AGP 9.0.1 / Kotlin 2.x toolchain can compile the plugin (8.14.2 hardcodes Kotlin languageVersion 1.6, dropped in Kotlin 2.x) Verified: flutter build apk --debug succeeds. Release signing (make build-android) remains out of scope per plan; deferred to follow-up issue.
The generated android/app/build.gradle.kts signs the release build with the debug keystore (Flutter default) and does not read key.properties. Add a NOTE to the example so it stays accurate, per plan Risk 2 (update the example when the generated release-signing block diverges). Real release signing is tracked in the follow-up issue.
Contributor
Author
Review: Changes Requested — Tech DebtThe Android Gradle scaffolding is regenerated correctly and the debug build succeeds (verified: One tech_debt finding: the disclosed release-signing follow-up issue does not exist. Rubric
Pre-Verdict Checklist
Verified
Blockers
Tech Debt
Nits
Miscellaneous
Acknowledged Deferrals (verified)
Verification Results
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the missing Android Gradle scaffolding so the template builds for Android.
Closes #13
Changes
flutter create --platforms=android:AndroidManifest.xml,build.gradle.kts,settings.gradle.kts, Gradle wrapper, resources.minSdk = 23(required by flutter_secure_storage 9.x, per docs/setup_reference.md).sentry_flutter8.14.2 -> 9.27.0: required so the generated AGP 9.0.1 / Kotlin 2.3.20 toolchain can compile the plugin (8.14.2 hardcodes KotlinlanguageVersion 1.6, dropped in Kotlin 2.x).key.properties.examplethat release signing via key.properties is deferred to the follow-up issue Release signing: key.properties + keystore for make build-android #18.Verification
flutter build apk --debugsucceeds (exit 0).applicationId=com.example.flutter_template(derives from pubspecflutter_template; substring match per plan).Out of scope (per plan)
Release signing (
make build-android/flutter build apk --release) is NOT verified here; deferred to follow-up issue #18 "Release signing: key.properties + keystore for make build-android".