Isolate provenance verification downloads - #40
Conversation
📝 WalkthroughWalkthroughThe release verification example now uses a strict subshell, temporary directory, cleanup trap, and temporary paths for attestation checks. Contract tests verify these changes and the ChangesRelease verification
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_workflow_release_contract.py`:
- Around line 833-836: The README contract test assertions should explicitly
verify that both gh attestation verify commands reference "$verify_dir/..."
artifact paths. Update the assertions near the existing verify_dir and
source-ref checks in the test covering the documented verification flow,
preserving the current checks while distinguishing and validating each temporary
attestation path.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0eab9563-7abc-4951-b662-912de6d993b2
📒 Files selected for processing (2)
README.mdtests/test_workflow_release_contract.py
Summary
Verification
TMPDIR=/tmp TEMP=/tmp TMP=/tmp .venv/bin/python -m pytest -qactionlintbash -n, Python compilation, andshellcheck.venv/bin/python scripts/check_changelog.pyBoundary check