ci: validate self-dogfood evidence before upload - #41
Conversation
📝 WalkthroughWalkthroughThe CI self-dogfood workflow now uses ChangesCanonical evidence flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 159987893b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_workflow_release_contract.py`:
- Around line 589-619: Extend the assertions in the self-dogfood workflow check
around normalized_self_dogfood to require the canonical renamed report-consumer
commands: conformance check using --evidence and evidence-pack manifest using
both --report and --artifact. Assert each command’s exact expected path,
alongside the existing report and consumer_command checks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5ed92dc3-906b-4c2c-856d-f8e6878f777d
📒 Files selected for processing (3)
.github/workflows/ci.ymlCHANGELOG.mdtests/test_workflow_release_contract.py
Summary
Verification
TMPDIR=/tmp TEMP=/tmp TMP=/tmp .venv/bin/python -m pytest -s -qactionlint .github/workflows/ci.yml .github/workflows/release.yml .github/workflows/github-release.yml.venv/bin/python scripts/check_changelog.pygit diff --checkBoundary check