Skip to content

Fix atomic entity writes and scoped git identity#109

Open
yusufm wants to merge 1 commit intomainfrom
codex/fix-review-findings-atomic-identity
Open

Fix atomic entity writes and scoped git identity#109
yusufm wants to merge 1 commit intomainfrom
codex/fix-review-findings-atomic-identity

Conversation

@yusufm
Copy link
Copy Markdown
Owner

@yusufm yusufm commented Mar 18, 2026

Summary

  • make entity and events writes atomic via temp-file replacement to avoid truncation/corruption on failed writes
  • scope request git identity through git subprocess env overrides instead of mutating process-global os.environ
  • preserve text_size_text on sticker batch error renders and add focused regression coverage

Validation

  • pytest -q tests/test_git_workflow.py tests/test_web_identity_headers.py tests/test_entities_core_behavior.py

Notes

  • the CLI repo-wide locking concern remains broader than inventory post alone and should be handled as a separate follow-up across all mutating CLI paths

env = os.environ.copy()
env.update(env_overrides)
return subprocess.run(
args,

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
This command line depends on a
user-provided value
.
This command line depends on a
user-provided value
.
This command line depends on a
user-provided value
.
This command line depends on a
user-provided value
.
This command line depends on a
user-provided value
.

Copilot Autofix

AI 23 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants