Skip to content

refactor(schemas): replace hand-rolled loop with a list comprehension in normalize_claim_navigation_hints #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhruvbatra merged 1 commit into from
Aug 25, 2026
Merged

refactor(schemas): replace hand-rolled loop with a list comprehension in normalize_claim_navigation_hints #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/frontend_visualqa/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,14 +213,7 @@ def validate_claims(cls, value: list[str]) -> list[str]:
def normalize_claim_navigation_hints(cls, value: list[str | None] | None) -> list[str | None] | None:
if value is None:
return None
normalized: list[str | None] = []
for hint in value:
if hint is None:
normalized.append(None)
continue
stripped = hint.strip()
normalized.append(stripped or None)
return normalized
return [None if hint is None else (hint.strip() or None) for hint in value]

@model_validator(mode="after")
def validate_claim_navigation_hint_alignment(self) -> "VerifyVisualClaimsInput":
Expand Down