Skip to content

test: extract shared _runner_aliased_attrs helper in test_runner.py #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhruvbatra merged 1 commit into from
Aug 29, 2026
Merged

test: extract shared _runner_aliased_attrs helper in test_runner.py #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions tests/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,22 @@ async def _skip_preflight(url: str) -> None:
return None


def _runner_aliased_attrs(browser: FakeBrowserManager, verifier: Any, artifacts: FakeArtifactManager) -> dict[str, Any]:
"""Shared alias-attribute map for ``instantiate_with_aliased_attrs(VisualQARunner, ...)``.

Covers both the current attribute names and their legacy aliases, matching
whichever constructor signature the module under test still exposes.
"""
return {
"browser_manager": browser,
"browser": browser,
"claim_verifier": verifier,
"verifier": verifier,
"artifact_manager": artifacts,
"artifacts": artifacts,
}


def _build_runner(
module: Any,
tmp_path: Path,
Expand All @@ -254,14 +270,7 @@ def _build_runner(

runner = instantiate_with_aliased_attrs(
module.VisualQARunner,
{
"browser_manager": browser,
"browser": browser,
"claim_verifier": verifier,
"verifier": verifier,
"artifact_manager": artifacts,
"artifacts": artifacts,
},
_runner_aliased_attrs(browser, verifier, artifacts),
reporters=reporters,
)

Expand All @@ -283,14 +292,7 @@ def _build_visualize_override_runner(
skipped preflight check, for tests exercising per-call visualize overrides."""
runner = instantiate_with_aliased_attrs(
module.VisualQARunner,
{
"browser_manager": browser,
"browser": browser,
"claim_verifier": verifier,
"verifier": verifier,
"artifact_manager": artifacts,
"artifacts": artifacts,
},
_runner_aliased_attrs(browser, verifier, artifacts),
browser_config=BrowserConfig(visualize=False),
navigator_client=FakeNavigatorClient([]),
)
Expand Down
Loading