Prevent synthetic worker PIDs from signaling real processes in tests - #166
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthetic worker PIDs could reach real
process.killafter a simulated crash or rehydration, causing an unrelated process to receive SIGTERM/SIGKILL if its PID matched. PR #165 and its main run exited 143; the recorded cleanup timing strongly implicates fake PID 2401, although CI does not identify the victim.Route every InstanceManager PID signal and liveness probe through an instance-scoped dependency that defaults to the existing OS behavior. All synthetic fixtures inject a safe boundary; regression tests assert TERM, process-group/PID escalation and exit probes. Remove the global process.kill monkeypatch.
The complete run then exposed two CLI-specific router tests that assumed the former default. They now explicitly select CLI and restore the setting afterward; the separate App-default routing/reservation test continues to exercise the new default.
Validation: npm test 753 passed, 0 failed, npm run typecheck, npm run build, git diff --check, and independent code review. Production signal behavior is unchanged. This repairs CI after #165; it does not grant product acceptance or bypass any Cyberent audit gate.