Scene refact4#11
Merged
Merged
Conversation
Fix inventory-backed scene entity deletion, parser visibility, and LOOK/EXAMINE spatial reveal semantics. Details: - Clean up the broken test_room cassette state so the held Compact cassette is represented by the real scene entity instead of a stale phantom entry. - Remove inventory references when editor deletion removes a scene entity, preventing Inventory/Surface storage from retaining non-existing objects. - Preserve the distinction between Inventory ownership and generic spatial IN relations, so objects inside world containers such as CityView in Window are not hidden as inventory items. - Add direct semantic descendant helpers for scene text, collapsing untitled technical intermediates while stopping at titled children. - Make LOOK and EXAMINE describe and reveal only first-level titled semantic children of the inspected target. - Keep recursive relation traversal for TAKE FROM and related containment semantics where deeper target discovery is intentional. - Update parser/game fixture helpers and regression tests for hidden lookable objects under nested titled children. - Update nested cabinet expectations so LOOK reports only immediate semantic contents while TAKE FROM still reaches nested candidates. - Include current scene, prompt, llm-cascade, and kitchen asset work already present in the workspace as part of this all-in Fixes commit. Validation: - npm test -- tests/integration/parser-game.test.ts -- --runInBand - npm run typecheck - npm test -- tests/game/navigation-and-spatial.test.ts tests/game/semantic-api.test.ts tests/integration/parser-game.test.ts -- --runInBand - npm test - codex-doctor -Fast
… mouse is over canvas
…ows for navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.