Skip to content

fix: 隔离 Hook 性能门槛以稳定 CI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
z2z23n0 merged 1 commit into from
Jul 17, 2026
Merged

fix: 隔离 Hook 性能门槛以稳定 CI #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/cli/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,6 +785,8 @@ func TestHookRejectsFlagPayloadEventMismatch(t *testing.T) {
}

func TestHookCLIWithSQLiteMeetsP95Budget(t *testing.T) {
skipHookPerformanceTestWhenRequested(t)

var seedOut, seedErr bytes.Buffer
base := testOptions(t, &seedOut, &seedErr, strings.NewReader(""))
paths := config.ResolveWith(base.HomeDir, base.Getenv)
Expand Down Expand Up @@ -820,6 +822,8 @@ func TestHookCLIWithSQLiteMeetsP95Budget(t *testing.T) {
}

func TestHookProcessMeetsP95Budget(t *testing.T) {
skipHookPerformanceTestWhenRequested(t)

var seedOut, seedErr bytes.Buffer
base := testOptions(t, &seedOut, &seedErr, strings.NewReader(""))
paths := config.ResolveWith(base.HomeDir, base.Getenv)
Expand Down Expand Up @@ -860,6 +864,13 @@ func TestHookProcessMeetsP95Budget(t *testing.T) {
}
}

func skipHookPerformanceTestWhenRequested(t *testing.T) {
t.Helper()
if os.Getenv("TOOLTEND_TEST_SKIP_HOOK_PERFORMANCE") == "1" {
t.Skip("hook performance tests run separately from the shared package suite")
}
}

func TestHookProcessHelper(t *testing.T) {
if os.Getenv("TOOLTEND_TEST_HOOK_PROCESS") != "1" {
return
Expand Down
3 changes: 2 additions & 1 deletion scripts/ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ if ! git diff --exit-code -- go.mod go.sum; then
exit 1
fi
"$GO_BIN" vet ./...
"$GO_BIN" test ./...
TOOLTEND_TEST_SKIP_HOOK_PERFORMANCE=1 "$GO_BIN" test ./...
"$GO_BIN" test -count=1 ./internal/cli -run '^TestHook(CLIWithSQLite|Process)MeetsP95Budget$'
"$GO_BIN" build ./...
Loading