Conversation
Author
|
Tests are failing because they compare hashes of PDF outputs to pre-calculated values. The PDF hashes could either be updated in the tests or the tests could be re-written to just compare restored data with original data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the note at the top of a PDF output indicating what
qr-backupcommand you used to generate the document, the reported error correction code is wrong. For example, use the defaultMand the report will say you used--error-correction L. The reported value gets decoded by indexing the stringLMQHbut theqrcodemodule actually assignssee https://github.com/lincolnloop/python-qrcode/blob/main/qrcode/constants.py
The PR just decodes from a dictionary (i.e. by name) in case those values were to change.