Skip to content

Conversation

@zabetak
Copy link
Owner

@zabetak zabetak commented Dec 9, 2022

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug D 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zabetak
Copy link
Owner Author

zabetak commented Apr 29, 2025

@CodiumAI-Agent /review

@QodoAI-Agent
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Dead methods

The newly added methods newDeadMethod and anotherDeadMethod are unused stubs that call core APIs with null, introducing potential NullPointerExceptions and unnecessary complexity.

void newDeadMethod() {
  Random r = new Random();
  if (r.nextInt() > 100) {
    executeProgram(null);
  } else {
    executeRuleInstance(null, null);
  }
}
Random usage

The code uses new Random().nextInt() without an explicit bound, which may produce unexpected large values. Consider using nextInt(bound) or a shared instance.

Random r = new Random();
if (r.nextInt() > 100) {
Workflow configuration

The workflow references matrix.jdk for job-id but no matrix strategy is defined, leading to an undefined variable error during execution.

with:

@zabetak
Copy link
Owner Author

zabetak commented Apr 29, 2025

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link

QodoAI-Agent commented Apr 29, 2025

Title

(Describe updated until commit 2fc8039)

Add dead method to test code coverage output


PR Type

Enhancement


Description

  • Add dead methods to HepPlanner for coverage

  • Integrate Jacoco plugin and configure reports

  • Add SonarQube plugin and sonarcloud workflow

  • Remove legacy GitHub Actions workflows


Changes walkthrough 📝

Relevant files
Miscellaneous
1 files
HepPlanner.java
Add dead methods for coverage testing                                       
+19/-0   
Configuration changes
9 files
build.gradle.kts
Integrate Jacoco and SonarQube plugins                                     
+20/-0   
settings.gradle.kts
Add jacoco and SonarQube plugin management                             
+2/-0     
buildcache.yml
Remove build cache GitHub workflow                                             
+0/-44   
gradle-wrapper-validation.yml
Remove Gradle wrapper validation workflow                               
+0/-10   
main.yml
Remove main CI workflow file                                                         
+0/-456 
publish-non-release-website-updates.yml
Remove non-release website workflow                                           
+0/-81   
publish-website-on-release.yml
Remove release website workflow                                                   
+0/-71   
sonarcloud.yml
Add SonarCloud analysis workflow                                                 
+56/-0   
gradle.properties
Update Jacoco and SonarQube versions                                         
+6/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.

    @github-actions github-actions bot added stale and removed stale labels May 30, 2025
    @github-actions
    Copy link

    This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.

    @github-actions github-actions bot added stale and removed stale labels Jun 30, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants