fix: I address the 18 react-hooks lint warnings from the ESLint 9 upgrade - #191
Merged
Conversation
…rade Closes #190 One (app/faq/page.tsx) was a genuine issue, a running index counter mutated during render, replaced with a precomputed per-section offset. The other 17 are legitimate, documented patterns that this new rule set cannot distinguish from unsafe code, each is annotated with a scoped, justified eslint-disable rather than rewritten: - 14 cases of syncing React state from an external source on mount or dependency change (localStorage, DOM classList, a fetch), which is the pattern react.dev itself documents for effects - 1 intentional ref read in TelemetryChart.tsx that batches WebSocket pushes between polls rather than re-rendering on every message - 2 warnings on the same recursive-reconnect closure in useWebSocketTelemetry.ts, a standard self-referencing setTimeout pattern that is safe because the closure only runs after the function's own declaration has completed Removed the file-wide warn-level downgrade from eslint.config.mjs now that every flagged line has a precise justification instead.
zaccesss
commented
Aug 5, 2026
zaccesss
left a comment
Owner
Author
There was a problem hiding this comment.
Checked the faq/page.tsx rewrite against the original output (same numbering, now a pure computation), and spot-checked several of the eslint-disable justifications against the actual code, they hold up. Good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190
One (app/faq/page.tsx) was a genuine issue, a running index counter mutated during render, replaced with a precomputed per-section offset. The other 17 are legitimate, documented patterns that this new rule set cannot distinguish from unsafe code, each annotated with a scoped, justified eslint-disable rather than rewritten:
Removed the file-wide warn-level downgrade from eslint.config.mjs now that every flagged line has a precise justification instead.