Repository navigation
vacuum: drop needless borrows flagged by clippy on Rust 1.99 - #29
Open
Imaclean74 wants to merge 1 commit into
Open
Imaclean74 wants to merge 1 commit into
Imaclean74 wants to merge 1 commit into
Conversation
is_inline_flank captures only shared references, so the closure is Copy and can be passed to is_some_and by value. Rust 1.99's clippy flags the borrows (needless_borrows_for_generic_args), failing CI's `cargo clippy -- -D warnings` on master and every open PR.
This was referenced Oct 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the CI runner moved to Rust 1.99,
cargo clippy -- -D warningsfails onmaster(and therefore on every open PR) withneedless_borrows_for_generic_argsatsrc/dom/optimize/vacuum.rs:61:is_inline_flankcaptures only shared references, so the closure isCopyand can be passed tois_some_andby value. No behaviour change.Checked with Rust 1.99.0:
cargo clippy --all-targets -- -D warningsis clean, andcargo fmt --checkandcargo testpass.