Open
Conversation
Owner
|
Good idea! dont mind pulling the change. Just need to address the review comments |
zaidt
reviewed
Dec 26, 2018
|
|
||
|  | ||
|
|
||
| For convert 8bit binary to hex write it in format: |
| } else if (selection.length == 10 && selection.toUpperCase().substr(-10, 2) == '0B') { | ||
| bin = selection.substr(2, 10); | ||
| hex = this.bin2hex(bin); | ||
| dec = this.bin2dec(bin); |
Owner
There was a problem hiding this comment.
Is there a specific reason why the dec needs to be re-set? the decimal value is already set at line 28 "dec = parseInt(selection);"
| } | ||
| this.element.textContent = "Hex:" + hex + " Bin:" + this.formatBinary(bin) + " Dec:" + dec; | ||
| } else { | ||
| } else if (selection.length == 10 && selection.toUpperCase().substr(-10, 2) == '0B') { |
Owner
There was a problem hiding this comment.
Can you please make the length variable instead of 10? i.e. a values "0b11011" should be valid. btw, line 28 "dec = parseInt(selection);" validates if the string is a number, if it fails the "if" is not entered, so you just need to check if te first 2 chars are "0b"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I think you will not mind if we add the ability to convert from binary to hex?