Skip to content

Replace 블링블링 반짝 - #4

Open
200mill wants to merge 1 commit into
zako-ac:mainfrom
200mill:patch-1
Open

Replace 블링블링 반짝#4
200mill wants to merge 1 commit into
zako-ac:mainfrom
200mill:patch-1

Conversation

@200mill

@200mill 200mill commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@attaccacode attaccacode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attacca Code Review

This PR edits the Korean emoji annotation data for ✨ (sparkles) in mappers/unicode-emoji/annotations/ko.xml: it adds the keyword 반짝 to the contributed keyword list and changes the type="tts" reading from 블링블링 to 반짝. The build (build.rs) only consumes the type="tts" annotations to generate the EMOJI_READINGS static table used by lib.rs, so the effective behavior change is that the ✨ grapheme now maps to the reading 반짝. The new value is valid, the keyword list and tts remain consistent (tts stays a subset of the keywords), and no test or other codepoint is affected. The non-tts keyword edit has no effect on mapper output since build.rs ignores non-tts annotations, but this is not a defect.

No issues found at or above the LOW severity threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant