Open
Conversation
szuecs
force-pushed
the
feature/flight-recorder
branch
from
74b6d67 to
e9d5125
Compare
szuecs
force-pushed
the
feature/flight-recorder
branch
2 times, most recently
from
b23465b to
c42035a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
szuecs
force-pushed
the
feature/flight-recorder
branch
from
f7e2831 to
b9d62b2
Compare
szuecs
force-pushed
the
feature/flight-recorder
branch
4 times, most recently
from
0498acc to
baa60cf
Compare
szuecs
force-pushed
the
feature/flight-recorder
branch
2 times, most recently
from
b073f6c to
fadd0fe
Compare
szuecs
commented
Sep 10, 2024
szuecs
commented
Sep 10, 2024
szuecs
commented
Sep 10, 2024
szuecs
force-pushed
the
feature/flight-recorder
branch
2 times, most recently
from
98f84bc to
904c64c
Compare
szuecs
commented
Sep 10, 2024
| p.FlightRecorder.Stop() | ||
| p.FlightRecorder = nil | ||
| } else { | ||
| go func() { |
Member
Author
There was a problem hiding this comment.
forever runs and tries to be an efficient way of handling multiple goroutines fire "we are slow" and write only once in an hour trace data to check.
szuecs
force-pushed
the
feature/flight-recorder
branch
4 times, most recently
from
22c3e06 to
40a3067
Compare
szuecs
force-pushed
the
feature/flight-recorder
branch
2 times, most recently
from
d879db9 to
e39547f
Compare
szuecs
added
major
szuecs
force-pushed
the
feature/flight-recorder
branch
2 times, most recently
from
d65aa82 to
bf08980
Compare
ponimas
reviewed
Oct 16, 2025
szuecs
force-pushed
the
feature/flight-recorder
branch
from
bf08980 to
7a67eb8
Compare
szuecs
force-pushed
the
feature/flight-recorder
branch
from
7a67eb8 to
935a845
Compare
config: allow configuration for Go runtime/trace.FlightRecorder pass default period to define what means skipper to be slow config: set defaults to 100ms is slow and max 16MB trace file size Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
szuecs
force-pushed
the
feature/flight-recorder
branch
from
935a845 to
ffc83f5
Compare
…test output Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Member
|
👍 |
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature: flightrecorder to enable Go trace
https://go.dev/blog/execution-traces-2024https://pkg.go.dev/golang.org/x/exp/trace#FlightRecorder2025: https://go.dev/blog/flight-recorder
FlightRecorder got a bit more attraction from Go team, so I think we should be able to integrate this.
stdlib package https://pkg.go.dev/runtime/trace#FlightRecorder
Ideas from discussion