feat: add single active consumer feature - #16
Merged
mm-zacharydavison merged 5 commits intoAug 7, 2026
Merged
Conversation
GuillaumeDecMeetsMore
marked this pull request as ready for review
July 24, 2026 03:03
GuillaumeDecMeetsMore
requested review from
iebb,
mm-derek and
mm-zacharydavison
July 24, 2026 03:03
mm-derek
approved these changes
Jul 30, 2026
Comment on lines
+612
to
+615
| This is exposed programmatically via `Transport.capabilities`: | ||
|
|
||
| - `ordering`: `'none'` (no guarantee — the default for `RabbitMQTransport` with more than one consumer), `'queue'` (strict FIFO — `LocalTransport`, or `RabbitMQTransport` when configured per [Single active consumer](#single-active-consumer) below), or `'partition'` (ordered within a partition/key, for future partition-aware transports). | ||
| - `concurrencyModel`: how the transport parallelizes work (`'prefetch'` for RabbitMQ, `'worker'`, `'partition'`, or `'none'`). |
Collaborator
There was a problem hiding this comment.
Is this actually configurable via Matador, or just for background information?
Collaborator
There was a problem hiding this comment.
Transport.capabilities statically returns the capabilities of a given transport, it's not a configuration point.
That said, it doesn't seem like this PR adds anything to make this true?
mm-zacharydavison
requested changes
Aug 4, 2026
Comment on lines
+612
to
+615
| This is exposed programmatically via `Transport.capabilities`: | ||
|
|
||
| - `ordering`: `'none'` (no guarantee — the default for `RabbitMQTransport` with more than one consumer), `'queue'` (strict FIFO — `LocalTransport`, or `RabbitMQTransport` when configured per [Single active consumer](#single-active-consumer) below), or `'partition'` (ordered within a partition/key, for future partition-aware transports). | ||
| - `concurrencyModel`: how the transport parallelizes work (`'prefetch'` for RabbitMQ, `'worker'`, `'partition'`, or `'none'`). |
Collaborator
There was a problem hiding this comment.
Transport.capabilities statically returns the capabilities of a given transport, it's not a configuration point.
That said, it doesn't seem like this PR adds anything to make this true?
…-only Transport.capabilities is static per transport; queue options do not change it. RabbitMQTransport reports ordering: 'none' regardless of singleActiveConsumer, so drop the claim that it reports 'queue'. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
GuillaumeDecMeetsMore
deleted the
guillaume/feat/add-rabbitmq-single-active-consumer
branch
August 7, 2026 07:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed