Repository navigation
fix: subscriber idempotency handling - #20
Merged
mm-zacharydavison merged 4 commits intoAug 18, 2026
Merged
mm-zacharydavison merged 4 commits into
mm-zacharydavison merged 4 commits into
Conversation
mm-derek
commented
Aug 17, 2026
| await matador.start(); | ||
|
|
||
| // Wait for processing | ||
| await matador.waitForIdle(10_000); |
Collaborator
Author
There was a problem hiding this comment.
This seems flaky and I don't think related to the timeout value actually. Maybe a race condition with the isIdle check actually completing before processing has started?
Needs some more thought.
Collaborator
There was a problem hiding this comment.
given it's polling for idle rather than just waiting for 10_000 i don't think it's too bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscriber
idempotentsetting was not working for both cases:idempotentset tonoidempotentset tono