agent: Surface title generation error reason in tooltip instead of generic "Retry"#57659
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
When title generation fails the tooltip just said "Title generation failed. Retry" with no indication of why. For common, actionable failures (Anthropic 200K context overflow, rate limits, auth errors), the user has no way to know whether to switch model, wait, or fix configuration without opening the thread and re-running.
Replaced the bool
title_generation_failedonThreadwithOption<SharedString>carrying the actual error message. Tooltip now reads the stored reason and surfaces it inline; the Retry action still works the same way. When the reason is too long, it's truncated to a single tooltip-friendly line.Tests verify the option round-trips through retry, that successful generation clears it, and that a long upstream message gets truncated rather than overflowing.
Closes #57117
Release Notes:
AI was used for assistance.