Holy Grail doesn't work with the latest Diablo 2 Resurrected - Reign of the Warlock

[jakub-astrahit]

Getting this error:

Some save files could not be read: ...

Version of the game: 3.1.91636

[csvon]

I guess we'll need a d2s (or fork) to be updated?

[viniciusrezende]

Yesterday I fiddled with d2s and TheHolyGrail fork(pyrosplat/TheHolyGrail) in order to continue my holy grail run.

I can patch both, but I am still dealing with electron build issues... and I've tried all node major versions from v14 through v24.

I will keep trying and I will make it working with v105/ressurected save files. But to support the new expansion I will need help with the new constants/items. Since I decided to not buy the realm of the warlock.

[viniciusrezende]

@jakub-astrahit pyrosplat#13
I can try to cherry pick the changes and create a PR here

[csvon]

Yesterday I fiddled with d2s and TheHolyGrail fork(pyrosplat/TheHolyGrail) in order to continue my holy grail run.

I can patch both, but I am still dealing with electron build issues... and I've tried all node major versions from v14 through v24.

I will keep trying and I will make it working with v105/ressurected save files. But to support the new expansion I will need help with the new constants/items. Since I decided to not buy the realm of the warlock.

I think I remember having to add win32 platform to run electron on Windows @viniciusrezende :

"makers": [ { "name": "@electron-forge/maker-squirrel", "config": { "name": "d2rholygrail", "setupIcon": "./assets/install.ico", "iconUrl": "https://raw.githubusercontent.com/zeddicus-pl/d2rHolyGrail/master/assets/icon.ico" } }, { "name": "@electron-forge/maker-zip", "platforms": ["win32"] }, { "name": "@electron-forge/maker-zip", "platforms": ["darwin"] } ]

[vismajor01]

Dears,

Let me know how can we help. I am on 99% and the new built in holygrail does not recognise my previous items, and my favorite holygrail app can't read rotw characters, so it seems i am screwed both ways...

So a solution to this would be life changing

[viniciusrezende]

@vismajor01 I have a working copy of the TheHolyGrail fork for Expansion(LOD/non RotW) - https://github.com/viniciusrezende/TheHolyGrail/releases/tag/0.0.1

I already added the constants for the 105v in my d2s fork. I can try to:

1. support the RotW save files (I need examples of the currency/gem tabs and the 5 different shared stashes, save files of the Warlock and new items (runewords inclusive)
2. try to cherry-pick my changes made to TheHolyGrail repo to the d2rHolyGrail repo and see if it works

[vismajor01]

@vismajor01 I have a working copy of the TheHolyGrail fork for Expansion(LOD/non RotW) - https://github.com/viniciusrezende/TheHolyGrail/releases/tag/0.0.1

I already added the constants for the 105v in my d2s fork. I can try to:

1. support the RotW save files (I need examples of the currency/gem tabs and the 5 different shared stashes, save files of the Warlock and new items (runewords inclusive)
2. try to cherry-pick my changes made to TheHolyGrail repo to the d2rHolyGrail repo and see if it works

Hi @viniciusrezende

I've downloaded your copy and it can read more characters but still there are lot of errors (original shows 74%, this version shows 97%)

1. Let me know what can i do to help you obtain these
2. I am not sure what you mean by cherry-picking "theholygrail" repo and "d2rholygrail " repo :/

[viniciusrezende]

@vismajor01

Can you share your save files? Can you provide more info? Are they RotW/Expansion/Classic?

Also, check the save game summary and let me know which ones it couldn't read properly

Cherry-picking in a git context is just applying my changes to this(d2rHolyGrail) repository. Thus allowing my changes to be merged.

If you can provide your saves that it couldn't read, that would be perfect

[vismajor01]

Errors.zip

Attached. Also it shows error for random characters i do not have,
https://i.imgur.com/Dz9Vg92.png

[viniciusrezende]

@vismajor01 thanks! I am going to take a brief look at it during the night and more extensively during the weekend.

Can you check if there is any D2I files as well? in my case it's called SharedStashSoftCoreV2.d2i

Edit: I just ran a scan on the files and found the following: craftedammies.d2s is filled with null data and Lyukasok.d2s has plaintext inside it
Can you check if this is expected? can you open these chars ingame?

thanks

[vismajor01]

@viniciusrezende

Yes i have 2 d2i for sc and hc, and d2i.bak for both sc and hc. Attached

Craftedammies: The d2s file is in the folder but i can't find the character ingame.

Lyukasok: I couldn't find this char either, but i copied one from one of my saves and now i can access the char but it still throws error on it in the app (not that there is anything on it to read since its full with socketables). What do you mean "has a plaintext"? I attached this one as well, maybe it is different

Lyukasok.zip

SharedStashSoftCoreV2.zip

[csvon]

I was also deep into my Grail. I tried a bunch of forks and PRs and couldn’t get anything to work. I ended up tweaking the code, and now it works (at least for me). I’ve pushed it here in case it helps anyone: https://github.com/csvon/TheHolyGrail/

[viniciusrezende]

@csvon thanks pal

I cherry-picked my changes and got it working for this repo(zeddicus-pl/d2rHolyGrail) as well https://github.com/viniciusrezende/TheHolyGrail/tree/feat/d2rhr-support-reign-of-warlock

I will change my effort during the weekend and try to add support for the new items instead

[Savaal]

New here, sorry if I'm being a noob. I used yarn and ran both of your most recent forks. Csvon's fork recognizes more of the standard items, but save file reading for the active character fails 50% of the time. Vini, yours sees far less items for some reason.

I play every day, have a very old (read: very rusty) programming background. happy to troubleshoot if you want to try to offload some tasks to me. I'll understand if not.

Probably can't write much new code, but I can parse files, gather/format data, make small mods to code, and do QA testing for RotW if helpful.

Or just tell me to buzz off. :)

Thx.

[vismajor01]

@vismajor01 thanks! I am going to take a brief look at it during the night and more extensively during the weekend.

Can you check if there is any D2I files as well? in my case it's called SharedStashSoftCoreV2.d2i

Edit: I just ran a scan on the files and found the following: craftedammies.d2s is filled with null data and Lyukasok.d2s has plaintext inside it Can you check if this is expected? can you open these chars ingame?

thanks

@viniciusrezende

Hi, did you have the time to check? I'd love to have a working holy grail app, but i understand it takes time