Draft
Conversation
# Conflicts: # zeeguu/core/model/friend.py
…r /get_friend_requests
|
ArchLens detected architectural changes in the following views: |
Member
There was a problem hiding this comment.
Do we still want these scripts to generate test data?
Member
There was a problem hiding this comment.
And this script to generate fake data? Do we want that?
| from zeeguu.core.model.user_avatar import UserAvatar | ||
|
|
||
|
|
||
| def exercise_time_leaderboard( |
Member
There was a problem hiding this comment.
Currently this leaderboard has a limit of 20, should we keep that?
|
|
||
| def read_articles_leaderboard( | ||
| user_ids_subquery, | ||
| limit: int = 20, |
| receiver_id = Column(Integer, ForeignKey("user.id"), nullable=False) | ||
| status = Column( | ||
| Enum("pending", "accepted", "rejected", name="friend_request_status"), | ||
| Enum("pending", "accepted", "rejected", name="friend_request_status"), # TODO Do we need these? We basically only use pending since the request is deleted in both other cases |
Member
There was a problem hiding this comment.
Currently we do not use the status enum. So maybe it should be deleted. But it could also stay for future use?
|
|
||
| @classmethod | ||
| def find_by_username(cls, username): | ||
| return User.query.filter(User.username == username).one() |
Member
There was a problem hiding this comment.
How is the behaviour of this. Can it throw and error?
If no user matches: raises NoResultFound. ?
If more than one matches: raises MultipleResultsFound.?
And do we handle that?
This was referenced Apr 2, 2026
Skip expensive tokenization when caller only needs article metadata (id, language, title). Used by SharedArticleHandler to show the language choice modal immediately without waiting for NLP processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Downloads and detects language + title without creating the article in the DB. Returns instantly for already-existing articles. Reverts the withContent flag — no longer needed since the share flow now uses this lightweight endpoint instead of find_or_create_article. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.