Support suggestion_type for audio lesson generation#518
Merged
mircealungu merged 6 commits intomasterfrom Apr 3, 2026
Merged
Conversation
Accept "topic" or "situation" as suggestion_type alongside topic_suggestion. Use different LLM prompt phrasing: topics set a thematic context while situations structure the lesson as a roleplay. Word/char limits relaxed to 6 words / 48 chars. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
ArchLens detected architectural changes in the following views: |
Add suggestion_type column to daily_audio_lesson and audio_lesson_meaning tables. Includes migration script. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previously only topic_suggestion text was compared when checking whether to regenerate. Now suggestion_type is also compared, and included in the lesson response dict. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Rename column and all references from topic_suggestion to suggestion since the field now covers both topics and situations. Includes migration to rename the DB column. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suggestion_typeparameter ("topic" or "situation") alongsidetopic_suggestionVALID_SUGGESTION_TYPESconstant to avoid stringly-typed validationTest plan
suggestion_type=topic+topic_suggestion=cooking→ prompt contains TOPIC directivesuggestion_type=situation+topic_suggestion=job interview→ prompt contains SITUATION directivesuggestion_type=foo→ silently treated as topictopic_suggestion→suggestion_typeis ignored🤖 Generated with Claude Code