Fix: null-guard getDailyStreak and topic callbacks#1007
Open
mircealungu wants to merge 1 commit intomasterfrom
Open
Fix: null-guard getDailyStreak and topic callbacks#1007mircealungu wants to merge 1 commit intomasterfrom
mircealungu wants to merge 1 commit intomasterfrom
Conversation
…BP, ZEEGUU-WEB-DN) Prevents TypeErrors when API calls return null on network failure. Long-term solution tracked in #1006 (global toast + React Query). https://claude.ai/code/session_01Gy24MmyjQbi9P2qunHLWhw
✅ Deploy Preview for voluble-nougat-015dd1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two Sentry crashes caused by
_getJSONcallingcallback(null)on network failure:ProgressContext.jsnull.daily_streakuseSelectInterest.jsMinimal fix: guard each callback before dereferencing. The long-term solution (global toast on network failure) is tracked in #1006.
Supersedes #1003 (which also fixed
App.js— already covered by the promise migration in master).https://claude.ai/code/session_01Gy24MmyjQbi9P2qunHLWhw