data: Fill symbols#167
Merged
Merged
Conversation
Collaborator
|
Can you squash it to one commit? |
Contributor
Author
|
Sure. I need to look up at some of the mismatches. Not sure if they are true mismatches or I set the symbol wrong. I will probably do that tomorrow |
german77
force-pushed
the
submodule
branch
3 times, most recently
from
28fa84e to
c94f03d
Compare
Contributor
Author
|
Done. Can you check the implementation of |
Collaborator
|
@german77 It's |
Pistonight
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filling mostly sead symbols from SMO. Some botw functions are too different. Specially the ones with graphics seem to be two different versions. I skipped those. This PR also updates sead to grab a bit more matches
This change is