Decompile overlay 24 (Part 3) by Yanis002 · Pull Request #68 · zeldaret/st

Yanis002 · 2026-05-24T16:13:17Z

I might do whatever's left in that overlay from now 💪

decomp-dev · 2026-05-24T16:14:26Z

Report for jp (`5a89296` - `81991a8`)

📈 Matched code: 5.74% (+0.32%, +14912 bytes)
📈 Linked code: 1.85% (+0.27%, +12534 bytes)
📈 Matched data: 23.68% (+0.06%, +828 bytes)
📈 Linked data: 0.48% (+0.02%, +296 bytes)

✅ 167 new matches

Unit	Item	Bytes	Before	After
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d2cfc(unsigned char (*) [15], int, int)`	+868	0.00%	100.00%
`src/024_MainGame/PlayerActor_A0_38_024`	`PlayerActor_A0_38_18::vfunc_00()`	+512	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_00::func_ov024_020cfb7c(UnkDataStruct4, Vec2s, int, unsigned short, int, int)`	+472	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d002c(UnkDataStruct4 const*)`	+436	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_00::func_ov024_020cf9d4(UnkStruct_027e0cf8_00_18_00*)`	+424	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d280c()`	+420	0.00%	100.00%
`src/001_SceneInit/UnkStruct_027e0cf8_08_00_001`	`UnkStruct_027e0cf8_08_00::func_ov001_020bfb20()`	+416	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`.data`	+364	0.00%	100.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c75d0(UnkDataStruct4*, int, unsigned short)`	+340	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_08_024`	`UnkStruct_027e0cf8_08::func_ov024_020d351c(int, int, int*, int, unsigned char)`	+340	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d258c(unsigned int, unsigned char)`	+292	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d01c0(UnkDataStruct4 const*)`	+288	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_08_00_024`	`UnkStruct_027e0cf8_08_00::func_ov024_020d3adc(Vec2s*, int, int, unsigned char, bool, unsigned char)`	+288	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d041c(Vec2s*)`	+244	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`.rodata`	+240	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d2a18(int, int, int, int, int)`	+240	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4_14`	`UnkDataStruct4_14::func_ov024_020d1ab8(int, int, int)`	+224	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4_14`	`UnkDataStruct4_14::func_ov024_020d20c0(int, int) const`	+224	0.00%	100.00%
`src/024_MainGame/ZeldaTrainBinary`	`ZTB_ParseGRRL`	+220	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_00::func_ov024_020cfd54(int, int, int, int)`	+208	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d26b0(int)`	+204	0.00%	100.00%
`src/001_SceneInit/UnkStruct_027e0cf8_08_00_001`	`UnkStruct_027e0cf8_08_00::UnkStruct_027e0cf8_08_00(unsigned char)`	+194	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d0340(Vec2s*, int)`	+184	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4_14`	`UnkDataStruct4_14::func_ov024_020d1eac(int)`	+180	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d2c54(unsigned char (*) [15], int)`	+168	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d0510(short)`	+160	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_08_024`	`UnkStruct_027e0cf8_08::func_ov024_020d3158(unsigned int)`	+160	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_08_024`	`UnkStruct_027e0cf8_08::func_ov024_020d336c(UnkDataStruct4*, int, int, int, int)`	+160	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::AdventureModeManager_1B8_Base(unsigned char, bool, AdventureModeManager_1B8_Base_1C const&, bool, bool)`	+148	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0ce0_34_024`	`UnkStruct_027e0ce0_34::func_ov024_020d3c60(SaveFile_00000_0000_Data_D8*)`	+148	0.00%	100.00%

...and 137 more new matches

🥀 7 broken matches

Unit	Item	Bytes	Before	After
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c75d0(void*, int, unsigned short)`	-340	100.00%	0.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::AdventureModeManager_1B8_Base(unsigned char, bool, AdventureModeManager_1B8_Base_1C const*, bool, bool)`	-148	100.00%	0.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c755c(void*)`	-116	100.00%	0.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c68d4()`	-24	100.00%	0.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c77b0(int)`	-16	100.00%	0.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c77c0()`	-16	100.00%	0.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c77d0()`	-16	100.00%	0.00%

📈 7 improvements in unmatched items

Unit	Item	Bytes	Before	After
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`.init`	+232	0.00%	80.85%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`__sinit_UnkStruct_027e0cf8_00_0C_024.cpp`	+232	0.00%	80.85%
`src/024_MainGame/ZeldaTrainBinary`	`ZTB_ParseFile`	+139	0.00%	99.92%
`src/024_MainGame/PlayerActor_A0_38_024`	`.init`	+62	0.00%	86.78%
`src/024_MainGame/PlayerActor_A0_38_024`	`__sinit_PlayerActor_A0_38_024.cpp`	+62	0.00%	86.78%
`src/024_MainGame/UnkStruct_027e0ce0_34_024`	`UnkStruct_027e0ce0_34::func_ov024_020d3da8(int, int)`	+21	0.00%	99.50%
`src/001_SceneInit/Actor/ActorManager_001`	`ActorManager::func_ov001_020bb018(UnkStruct_func_ov001_020bb018_param2*)`	+5	97.01%	97.54%

📉 3 regressions in unmatched items

Unit	Item	Bytes	Before	After
`src/024_MainGame/MiscAdvManager`	`MiscAdvManager::func_ov024_020d64b4(int, int, unsigned short*)`	-106	86.29%	0.00%
`src/024_MainGame/PassengerManager`	`PassengerManager::func_ov024_020d41bc(UnkStruct_Param1*)`	-46	83.57%	0.00%
`src/024_MainGame/PassengerManager`	`PassengerManager::GetRandomIndex(unsigned int, int)`	-40	44.22%	0.00%

Report for eur (`5a89296` - `81991a8`)

📈 Matched code: 5.77% (+0.32%, +14880 bytes)
📈 Linked code: 1.98% (+0.27%, +12534 bytes)
📈 Matched data: 23.80% (+0.06%, +828 bytes)
📈 Linked data: 0.52% (+0.02%, +296 bytes)

✅ 167 new matches

Unit	Item	Bytes	Before	After
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d2cfc(unsigned char (*) [15], int, int)`	+868	0.00%	100.00%
`src/024_MainGame/PlayerActor_A0_38_024`	`PlayerActor_A0_38_18::vfunc_00()`	+512	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_00::func_ov024_020cfb7c(UnkDataStruct4, Vec2s, int, unsigned short, int, int)`	+472	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_00::func_ov024_020cf9d4(UnkStruct_027e0cf8_00_18_00*)`	+424	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d280c()`	+420	0.00%	100.00%
`src/001_SceneInit/UnkStruct_027e0cf8_08_00_001`	`UnkStruct_027e0cf8_08_00::func_ov001_020bfb20()`	+416	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d002c(UnkDataStruct4 const*)`	+404	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`.data`	+364	0.00%	100.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c75d0(UnkDataStruct4*, int, unsigned short)`	+340	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_08_024`	`UnkStruct_027e0cf8_08::func_ov024_020d351c(int, int, int*, int, unsigned char)`	+340	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d258c(unsigned int, unsigned char)`	+292	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d01c0(UnkDataStruct4 const*)`	+288	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_08_00_024`	`UnkStruct_027e0cf8_08_00::func_ov024_020d3adc(Vec2s*, int, int, unsigned char, bool, unsigned char)`	+288	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d041c(Vec2s*)`	+244	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`.rodata`	+240	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d2a18(int, int, int, int, int)`	+240	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4_14`	`UnkDataStruct4_14::func_ov024_020d1ab8(int, int, int)`	+224	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4_14`	`UnkDataStruct4_14::func_ov024_020d20c0(int, int) const`	+224	0.00%	100.00%
`src/024_MainGame/ZeldaTrainBinary`	`ZTB_ParseGRRL`	+220	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_00::func_ov024_020cfd54(int, int, int, int)`	+208	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d26b0(int)`	+204	0.00%	100.00%
`src/001_SceneInit/UnkStruct_027e0cf8_08_00_001`	`UnkStruct_027e0cf8_08_00::UnkStruct_027e0cf8_08_00(unsigned char)`	+194	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d0340(Vec2s*, int)`	+184	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4_14`	`UnkDataStruct4_14::func_ov024_020d1eac(int)`	+180	0.00%	100.00%
`src/024_MainGame/UnkDataStruct4`	`UnkDataStruct4::func_ov024_020d2c54(unsigned char (*) [15], int)`	+168	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`UnkStruct_027e0cf8_0C::func_ov024_020d0510(short)`	+160	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_08_024`	`UnkStruct_027e0cf8_08::func_ov024_020d3158(unsigned int)`	+160	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0cf8_08_024`	`UnkStruct_027e0cf8_08::func_ov024_020d336c(UnkDataStruct4*, int, int, int, int)`	+160	0.00%	100.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::AdventureModeManager_1B8_Base(unsigned char, bool, AdventureModeManager_1B8_Base_1C const&, bool, bool)`	+148	0.00%	100.00%
`src/024_MainGame/UnkStruct_027e0ce0_34_024`	`UnkStruct_027e0ce0_34::func_ov024_020d3c60(SaveFile_00000_0000_Data_D8*)`	+148	0.00%	100.00%

...and 137 more new matches

🥀 7 broken matches

Unit	Item	Bytes	Before	After
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c75d0(void*, int, unsigned short)`	-340	100.00%	0.00%
`src/024_MainGame/Game/AdventureModeManager_1B8_Base_024`	`AdventureModeManager_1B8_Base::AdventureModeManager_1B8_Base(unsigned char, bool, AdventureModeManager_1B8_Base_1C const*, bool, bool)`	-148	100.00%	0.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c755c(void*)`	-116	100.00%	0.00%
`src/024_MainGame/Game/AdventureModeManager_024`	`AdventureModeManager::func_ov024_020c68d4()`	-24	100.00%	0.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c77b0(int)`	-16	100.00%	0.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c77c0()`	-16	100.00%	0.00%
`src/024_MainGame/Game/UnkStruct_027e0cf8_024`	`UnkStruct_027e0cf8::func_ov024_020c77d0()`	-16	100.00%	0.00%

📈 7 improvements in unmatched items

Unit	Item	Bytes	Before	After
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`.init`	+232	0.00%	80.85%
`src/024_MainGame/UnkStruct_027e0cf8_00_0C_024`	`__sinit_UnkStruct_027e0cf8_00_0C_024.cpp`	+232	0.00%	80.85%
`src/024_MainGame/ZeldaTrainBinary`	`ZTB_ParseFile`	+139	0.00%	99.92%
`src/024_MainGame/PlayerActor_A0_38_024`	`.init`	+62	0.00%	86.78%
`src/024_MainGame/PlayerActor_A0_38_024`	`__sinit_PlayerActor_A0_38_024.cpp`	+62	0.00%	86.78%
`src/024_MainGame/UnkStruct_027e0ce0_34_024`	`UnkStruct_027e0ce0_34::func_ov024_020d3da8(int, int)`	+21	0.00%	99.50%
`src/001_SceneInit/Actor/ActorManager_001`	`ActorManager::func_ov001_020bb018(UnkStruct_func_ov001_020bb018_param2*)`	+5	97.01%	97.54%

📉 3 regressions in unmatched items

Unit	Item	Bytes	Before	After
`src/024_MainGame/MiscAdvManager`	`MiscAdvManager::func_ov024_020d64b4(int, int, unsigned short*)`	-106	86.29%	0.00%
`src/024_MainGame/PassengerManager`	`PassengerManager::func_ov024_020d41bc(UnkStruct_Param1*)`	-46	83.57%	0.00%
`src/024_MainGame/PassengerManager`	`PassengerManager::GetRandomIndex(unsigned int, int)`	-40	44.22%	0.00%

name func_01ffd3d8 and func_01ffd400

50f09a9

Yanis002 added 22 commits May 24, 2026 18:19

name func_01ffd3b0

93b2baa

Merge remote-tracking branch 'upstream/main' into ov024-part3

bb86a33

match func_ov024_020cf9d4 + improve the Random struct

32765bb

UnkStruct_027e0cf8_00_0C_024 45%

ace9a56

match PassengerManager::GetRandomIndex

8706f48

UnkStruct_027e0cf8_00_0C_024 OK

56829f7

UnkStruct_027e0cf8_00_0C_024: do other sections

51146fa

UnkStruct_027e0cf8_08_024 55%

44e529d

cleanup: remplace delete into null by the delete macro

d0dc45b

UnkStruct_027e0cf8_08_024 OK

8e4ca63

Merge remote-tracking branch 'upstream/main' into ov024-part3

baccc32

fix build issues

4b17a10

UnkStruct_ov024_020d86a0_024 OK

6185290

Merge remote-tracking branch 'upstream/main' into ov024-part3

f78efc5

PlayerActor_A0_38_024 .text OK, CreditsEndingType OK

729177a

tools: create courselist.py to convert .CLB data to yaml

8f62bc9

UnkDataStruct4_14 OK

54a7a85

UnkDataStruct4 17%

2f6b039

UnkDataStruct4 OK

8142f41

MiscAdvManager OK

d76b5a5

PassengerManager OK

6d58746

fix build issues

632c151

Yanis002 linked an issue Jun 3, 2026 that may be closed by this pull request

Decompile PassengerManager #64

Open

Yanis002 added 5 commits June 3, 2026 16:29

ZeldaTrainBinary OK

423caa7

mark PassengerManager as complete and adjust delinks

b24a135

UnkStruct_027e0cf8_08_00_024 OK

d678810

document more of UnkStruct_027e0ce0

357bbec

Merge remote-tracking branch 'upstream/main' into ov024-part3

7d12970

Yanis002 added 2 commits June 4, 2026 00:00

savefile hotfixes

88e6910

UnkStruct_027e0ce0_34_024 OK

81991a8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decompile overlay 24 (Part 3)#68

Decompile overlay 24 (Part 3)#68
Yanis002 wants to merge 30 commits into
zeldaret:mainfrom
Yanis002:ov024-part3

Yanis002 commented May 24, 2026

Uh oh!

decomp-dev Bot commented May 24, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Yanis002 commented May 24, 2026

Uh oh!

decomp-dev Bot commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for jp (5a89296 - 81991a8)

Report for eur (5a89296 - 81991a8)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

decomp-dev Bot commented May 24, 2026 •

edited

Loading

Report for jp (`5a89296` - `81991a8`)

Report for eur (`5a89296` - `81991a8`)