Skip to content

Fix SaveFile struct#74

Merged
Yanis002 merged 2 commits into
zeldaret:mainfrom
Yanis002:savefile
Jun 3, 2026
Merged

Fix SaveFile struct#74
Yanis002 merged 2 commits into
zeldaret:mainfrom
Yanis002:savefile

Conversation

@Yanis002
Copy link
Copy Markdown
Collaborator

@Yanis002 Yanis002 commented Jun 3, 2026

during my overlay 24 adventures I encountered a function using this struct and since it was bad I started over, I was able to match the SaveFile ctor thanks to this

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented Jun 3, 2026

Report for jp (ecd0155 - 696eef2)

📈 Matched code: 5.41% (+0.01%, +396 bytes)

✅ 7 new matches
Unit Item Bytes Before After
src/019_MainSelect/019_SaveManager SaveFile::SaveFile() +266 19.01% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d14c0(SaveFile_00000_1D00_Data*) +60 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d14fc(SaveInfoData*) +60 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d1400(SaveFile_00000_2600_Data*) +52 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d15cc(SaveFile_00000_2500_Data*) +52 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d1600(SaveTreasureData*) +52 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveFile::func_ov019_020d0c4c(int, int) +14 80.59% 100.00%
🥀 5 broken matches
Unit Item Bytes Before After
src/019_MainSelect/019_SaveManager SaveSub5::func_ov019_020d14c0() -60 100.00% 0.00%
src/019_MainSelect/019_SaveManager SaveInfo::func_ov019_020d14fc() -60 100.00% 0.00%
src/019_MainSelect/019_SaveManager SaveSub7::func_ov019_020d1400() -52 100.00% 0.00%
src/019_MainSelect/019_SaveManager SaveSub6::func_ov019_020d15cc() -52 100.00% 0.00%
src/019_MainSelect/019_SaveManager SaveTreasures::func_ov019_020d1600() -52 100.00% 0.00%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
src/019_MainSelect/019_SaveManager SaveFile::func_ov019_020d1634() +126 1.03% 81.92%
src/019_MainSelect/019_SaveManager SaveFile::func_ov019_020d16d0() +75 54.65% 82.18%
src/019_MainSelect/019_SaveManager SaveFile::func_ov019_020d1b14(int) 0 86.51% 86.54%

Report for eur (ecd0155 - 696eef2)

📈 Matched code: 5.44% (+0.01%, +396 bytes)

✅ 7 new matches
Unit Item Bytes Before After
src/019_MainSelect/019_SaveManager SaveFile::SaveFile() +266 19.01% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d14c0(SaveFile_00000_1D00_Data*) +60 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d14fc(SaveInfoData*) +60 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d1400(SaveFile_00000_2600_Data*) +52 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d15cc(SaveFile_00000_2500_Data*) +52 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveSlot::func_ov019_020d1600(SaveTreasureData*) +52 0.00% 100.00%
src/019_MainSelect/019_SaveManager SaveFile::func_ov019_020d0c4c(int, int) +14 80.59% 100.00%
🥀 5 broken matches
Unit Item Bytes Before After
src/019_MainSelect/019_SaveManager SaveSub5::func_ov019_020d14c0() -60 100.00% 0.00%
src/019_MainSelect/019_SaveManager SaveInfo::func_ov019_020d14fc() -60 100.00% 0.00%
src/019_MainSelect/019_SaveManager SaveSub7::func_ov019_020d1400() -52 100.00% 0.00%
src/019_MainSelect/019_SaveManager SaveSub6::func_ov019_020d15cc() -52 100.00% 0.00%
src/019_MainSelect/019_SaveManager SaveTreasures::func_ov019_020d1600() -52 100.00% 0.00%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
src/019_MainSelect/019_SaveManager SaveFile::func_ov019_020d1634() +126 1.03% 81.92%
src/019_MainSelect/019_SaveManager SaveFile::func_ov019_020d16d0() +75 54.65% 82.18%
src/019_MainSelect/019_SaveManager SaveFile::func_ov019_020d1b14(int) 0 86.51% 86.54%

@Yanis002 Yanis002 merged commit 5a89296 into zeldaret:main Jun 3, 2026
3 checks passed
@Yanis002 Yanis002 deleted the savefile branch June 3, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant