STA-12: Bold setup launch flow redesign + UX polish#51
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ens,safe,startupchain) and phase failure pinningKey Changes
registration-progress-modeland testsregistration-error-copyand testsuse-company-registrationsetup-wizardandregistration-progress-cardper 3-row timeline specSidebarInset+ app layout wrapper to prevent overflow scrollValidation
yarn vitest run src/hooks/registration-error-copy.test.tsyarn vitest run src/hooks/registration-progress-model.test.tsyarn vitest run src/hooks/record-company-submit-guard.test.tsyarn vitest run 'src/app/(app)/dashboard/setup/actions.test.ts'yarn check(pass, existing unrelated lint warnings only)Greptile Summary
Replaced wizard-tab setup flow with a single bold compose surface and 3-phase launch timeline (ENS → Safe → StartupChain). Added deterministic phase view model and failure pinning for targeted retries. Wallet/provider errors are now sanitized into user-facing messages including proper cancel/signature-cancel handling. Layout overflow fixes ensure proper dashboard fit with sidebar visible. All changes have comprehensive test coverage and maintain reduced-motion-safe transitions.
Confidence Score: 5/5
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[User initiates registration] --> B[initializeRegistration] B --> C[awaiting-payment] C --> D{User pays} D -->|Payment sent| E[payment-pending] E -->|Confirmed| F[proceedAfterPayment] F --> G[committing] G --> H[waiting - ENS safety window] H -->|Countdown complete| I[completeRegistration] I --> J[deploying-safe] J --> K[registering-ens] K --> L[awaiting-signature] L -->|User signs| M[signing-company] M -->|Confirmed| N[completed] D -->|Error| O[failed - ENS phase] E -->|Error| O F -->|Error| O I -->|Error during Safe| P[failed - Safe phase] L -->|Error| Q[failed - StartupChain phase] M -->|Error| Q O -->|Retry| C P -->|Retry| I Q -->|Retry| I style N fill:#d4edda style O fill:#f8d7da style P fill:#f8d7da style Q fill:#f8d7daLast reviewed commit: 8365048