-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix:update default port number for the server from 8008 to 2311 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughUpdates: package version bump and keywords reformat; CLI default port changed from 8008 to 2311; server startup now adds model-meta loading via try/catch, improved error handling (EADDRINUSE) and red console output; minor path handling refactor for zenstack resolution. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the default port number for the ZenStack proxy server from 8008 to 2311 and bumps the package version from 0.2.6 to 0.2.7. The change also includes formatting improvements to the package.json file.
Changes:
- Updated the default port number from 8008 to 2311 in the CLI options
- Bumped package version from 0.2.6 to 0.2.7
- Reformatted the keywords array in package.json for better readability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.ts | Changed the default port value from '8008' to '2311' in the command-line option definition |
| package.json | Bumped version to 0.2.7 and reformatted keywords array to multi-line format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/server.ts`:
- Around line 256-267: The error handler for server.on('error', (err:
NodeJS.ErrnoException) => { ... }) should not throw an exception because that
prevents the following process.exit(1) from running; replace the throw new
CliError(...) in the else branch with a console.error (including err.message or
err) so the error is logged and the function continues to reach process.exit(1);
reference the existing handler and symbols (server.on('error', ...), err.code,
options.port, CliError) and ensure the logged message provides context before
exiting.
Summary by CodeRabbit
Chores
Changes
Bug Fixes / Reliability
✏️ Tip: You can customize this high-level summary in your review settings.