-
-
Notifications
You must be signed in to change notification settings - Fork 19
merge dev to main (v3.3.1) #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>
📝 WalkthroughWalkthroughPatch release: bumped many package versions from 3.3.0 → 3.3.1 across the monorepo; added explicit Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @ymc9's task —— View job PR Review: merge dev to main (v3.3.1)Review Tasks
Code Quality Analysis✅ Version ConsistencyAll 28 package.json files have been consistently updated to version
✅ Import Fixes (packages/clients/tanstack-query)The Fixed files:
These changes ensure proper module resolution in ESM environments where explicit file extensions are required for relative imports. Review Summary✅ Approved - Clean Release PRThis is a standard release merge with no issues found:
Recommendations
This PR successfully consolidates the v3.3.1 patch release changes from dev to main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR merges the dev branch to main for the v3.3.1 release, updating version numbers across all packages in the monorepo and fixing ES module import statements in the tanstack-query client package.
Changes:
- Bumped version from 3.3.0 to 3.3.1 across all packages (28 package.json files)
- Added
.jsextensions to relative imports in the tanstack-query package for proper ES module compatibility
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated root package version to 3.3.1 |
| packages/auth-adapters/better-auth/package.json | Updated version to 3.3.1 |
| packages/cli/package.json | Updated version to 3.3.1 |
| packages/clients/client-helpers/package.json | Updated version to 3.3.1 |
| packages/clients/tanstack-query/package.json | Updated version to 3.3.1 |
| packages/clients/tanstack-query/src/react.ts | Added .js extensions to relative imports for ES module compatibility |
| packages/clients/tanstack-query/src/vue.ts | Added .js extensions to relative imports for ES module compatibility |
| packages/clients/tanstack-query/src/svelte/index.svelte.ts | Added .js extensions to relative imports for ES module compatibility |
| packages/clients/tanstack-query/src/common/client.ts | Added .js extension to relative import for ES module compatibility |
| packages/common-helpers/package.json | Updated version to 3.3.1 |
| packages/config/eslint-config/package.json | Updated version to 3.3.1 |
| packages/config/typescript-config/package.json | Updated version to 3.3.1 |
| packages/config/vitest-config/package.json | Updated version to 3.3.1 |
| packages/create-zenstack/package.json | Updated version to 3.3.1 |
| packages/ide/vscode/package.json | Updated version to 3.3.1 |
| packages/language/package.json | Updated version to 3.3.1 |
| packages/orm/package.json | Updated version to 3.3.1 |
| packages/plugins/policy/package.json | Updated version to 3.3.1 |
| packages/schema/package.json | Updated version to 3.3.1 |
| packages/sdk/package.json | Updated version to 3.3.1 |
| packages/server/package.json | Updated version to 3.3.1 |
| packages/testtools/package.json | Updated version to 3.3.1 |
| packages/zod/package.json | Updated version to 3.3.1 |
| samples/orm/package.json | Updated version to 3.3.1 |
| tests/e2e/package.json | Updated version to 3.3.1 |
| tests/regression/package.json | Updated version to 3.3.1 |
| tests/runtimes/bun/package.json | Updated version to 3.3.1 |
| tests/runtimes/edge-runtime/package.json | Updated version to 3.3.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/ide/vscode/package.json`:
- Around line 2-5: The package.json for the VSCode extension currently sets
"version": "3.3.1" matching the monorepo; change the extension's version field
to follow its own extension-specific track (e.g., revert to the previous
extension version or use a dedicated sequence like 0.x or 1.x-ext) so it no
longer mirrors the monorepo releases; update the "version" value in the
package.json for the extension package (the object containing "name":
"zenstack-v3" and "displayName": "ZenStack V3 Language Tools") accordingly
before publishing to the VSCode Marketplace.
* fix(proxy): fix the problem when database url is a string literal * resolve comments * Get the string literal directly from the AST for datasource url
|
Claude finished @ymc9's task —— View job PR Review: merge dev to main (v3.3.1)Review Tasks
Code Quality Analysis✅ Version ConsistencyAll 28 package.json files have been consistently updated to version
✅ Import Fixes (packages/clients/tanstack-query)The Fixed files:
These changes ensure proper module resolution in ESM environments where explicit file extensions are required for relative imports. ✅ Proxy Changes (packages/cli/src/actions/proxy.ts)The changes to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/cli/src/actions/proxy.ts`:
- Around line 90-105: The evaluateUrl function currently assumes any
InvocationExpr is an env() call and that its first arg is a string literal;
update evaluateUrl to validate the invocation target name is "env" (or whatever
literal name is expected) and that args[0] exists and is a LiteralExpr, call
getStringLiteral on that arg and check its return value before using it (do not
use the non-null assertion), and if validation fails throw a CliError with a
clear message; then use the validated envName to read process.env and throw the
existing CliError if the env var is not set. Ensure these checks reference
InvocationExpr, getStringLiteral, and CliError so the logic matches the
defensive pattern used in datasource-validator.ts.
Summary by CodeRabbit
Chores
Bug Fixes
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.