Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Feb 1, 2026

Summary by CodeRabbit

  • Chores
    • Version 3.3.2 released across the entire framework, including all packages, CLI, server tools, and IDE extensions.
    • Improved type definitions for enhanced type safety and inference in the TanStack Query integration across React, Vue, and Svelte implementations.

✏️ Tip: You can customize this high-level summary in your review settings.

github-actions bot and others added 2 commits February 1, 2026 20:59
Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>
* fix(tanstack): build OOM type fix

* use Record<never, never> instead of {} for ProcedureHooks type

fixes #610
Copilot AI review requested due to automatic review settings February 1, 2026 13:55
@claude
Copy link

claude bot commented Feb 1, 2026

Claude finished @ymc9's task —— View job


PR Review Complete ✅

I've completed my review of this version bump PR (dev → main, v3.3.2). Here's my analysis:

Code Quality & Best Practices

  • Version consistency: All package.json files are properly updated to v3.3.2 ✓
  • TypeScript improvements: The TanStack query files contain a meaningful type safety fix
  • Workspace structure: Proper monorepo version synchronization using workspace dependencies ✓

📝 Key Changes Reviewed

1. Version Bumps (27 files)

  • Root package.json: 3.3.2
  • All workspace packages consistently updated to 3.3.2
  • VSCode extension package also updated (important for marketplace sync)

2. TanStack Query Type Fix (Issue #610)

  • Files changed: packages/clients/tanstack-query/src/react.ts:198-205, vue.ts:187-194, svelte/index.svelte.ts:185-192
  • Fix: Changed Schema extends { procedures: Record<string, any> }Schema['procedures'] extends Record<string, any>
  • Empty type fix: Changed {}Record<never, never> for better TypeScript strictness
  • Impact: Resolves out-of-memory (OOM) build issues during TypeScript compilation

Technical Assessment

Performance: The type changes are specifically designed to resolve build OOM issues - this is a performance improvement ✓

Security: No security concerns identified - this is purely version bumps + type fixes ✓

Compatibility:

  • Workspace dependency pattern (workspace:*) ensures internal compatibility ✓
  • Type changes are backwards compatible ✓
  • No breaking API changes ✓

Release Process Quality

  • Atomic release: All packages bumped together prevents version drift
  • Meaningful changes: Includes actual bug fix (TanStack OOM) alongside version bump
  • Proper branching: Following dev → main release flow ✓

🔍 Minor Observations

  1. Package manager version: Root package.json shows pnpm@10.23.0 but CLAUDE.md mentions pnpm@10.12.1 - consider updating docs if this was intentional
  2. Test coverage: Unable to verify test execution, but the type changes are low-risk
  3. Build verification: Consider running pnpm build and pnpm lint to ensure no regressions

Recommendation

APPROVE - This is a well-structured release PR with:

The OOM type fix is particularly valuable as build performance issues can significantly impact developer experience.


Review checklist completed:

  • Gather context and understand the changes
  • Review version consistency across all package.json files
  • Examine code changes in TanStack query files
  • Check for potential bugs or issues
  • Assess security and performance implications
  • Provide comprehensive review feedback

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2026

📝 Walkthrough

Walkthrough

The pull request bumps version numbers from 3.3.1 to 3.3.2 across 22 package.json files in the monorepo. Additionally, three source files in the tanstack-query package refine the ProcedureHooks type's conditional logic to check Schema['procedures'] directly and use Record<never, never> instead of {} for the false branch.

Changes

Cohort / File(s) Summary
Version Bumps – Root & Core Packages
package.json, packages/auth-adapters/better-auth/package.json, packages/cli/package.json, packages/clients/client-helpers/package.json, packages/clients/tanstack-query/package.json, packages/common-helpers/package.json, packages/orm/package.json, packages/schema/package.json, packages/sdk/package.json, packages/server/package.json, packages/testtools/package.json, packages/zod/package.json
Updated version field from 3.3.1 to 3.3.2 across core and client packages. No functional changes.
Version Bumps – Config Packages
packages/config/eslint-config/package.json, packages/config/typescript-config/package.json, packages/config/vitest-config/package.json
Version bumped from 3.3.1 to 3.3.2 in configuration packages. No behavioral changes.
Version Bumps – IDE, Language & Plugin
packages/ide/vscode/package.json, packages/language/package.json, packages/plugins/policy/package.json, packages/create-zenstack/package.json
Version updated from 3.3.1 to 3.3.2. No structural or functional modifications.
Version Bumps – Samples & Tests
samples/orm/package.json, tests/e2e/package.json, tests/regression/package.json, tests/runtimes/bun/package.json, tests/runtimes/edge-runtime/package.json
Version field incremented from 3.3.1 to 3.3.2 across test and sample packages. No changes to behavior or dependencies.
ProcedureHooks Type Refinement
packages/clients/tanstack-query/src/react.ts, packages/clients/tanstack-query/src/svelte/index.svelte.ts, packages/clients/tanstack-query/src/vue.ts
Refactored conditional type logic: changed from Schema extends { procedures: Record<string, any> } to Schema['procedures'] extends Record<string, any>, and updated false branch from {} to Record<never, never>. Improves type precision for schema validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A patch release hops into sight,
Twenty-two packages bumped just right—
And ProcedureHooks gained precision,
With cleaner types in each revision,
From 3.3.1 to 3.3.2, shining bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'merge dev to main (v3.3.2)' clearly summarizes the primary change: a version bump from 3.3.1 to 3.3.2 across multiple packages in the monorepo, with minor type refinements in tanstack-query clients.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges development changes to main for version 3.3.2, including a version bump across all packages and an important TypeScript type safety improvement in the tanstack-query client.

Changes:

  • Version bump from 3.3.1 to 3.3.2 across all 27 package.json files
  • Improved TypeScript type checking for ProcedureHooks to correctly handle optional procedures field using indexed access types
  • Changed empty object type from {} to Record<never, never> for better type safety

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Root package version updated to 3.3.2
packages/auth-adapters/better-auth/package.json Version bump to 3.3.2
packages/cli/package.json Version bump to 3.3.2
packages/clients/client-helpers/package.json Version bump to 3.3.2
packages/clients/tanstack-query/package.json Version bump to 3.3.2
packages/clients/tanstack-query/src/react.ts Improved type safety for ProcedureHooks with indexed access and Record<never, never>
packages/clients/tanstack-query/src/svelte/index.svelte.ts Improved type safety for ProcedureHooks with indexed access and Record<never, never>
packages/clients/tanstack-query/src/vue.ts Improved type safety for ProcedureHooks with indexed access and Record<never, never>
packages/common-helpers/package.json Version bump to 3.3.2
packages/config/eslint-config/package.json Version bump to 3.3.2
packages/config/typescript-config/package.json Version bump to 3.3.2
packages/config/vitest-config/package.json Version bump to 3.3.2
packages/create-zenstack/package.json Version bump to 3.3.2
packages/ide/vscode/package.json Version bump to 3.3.2
packages/language/package.json Version bump to 3.3.2
packages/orm/package.json Version bump to 3.3.2
packages/plugins/policy/package.json Version bump to 3.3.2
packages/schema/package.json Version bump to 3.3.2
packages/sdk/package.json Version bump to 3.3.2
packages/server/package.json Version bump to 3.3.2
packages/testtools/package.json Version bump to 3.3.2
packages/zod/package.json Version bump to 3.3.2
samples/orm/package.json Version bump to 3.3.2
tests/e2e/package.json Version bump to 3.3.2
tests/regression/package.json Version bump to 3.3.2
tests/runtimes/bun/package.json Version bump to 3.3.2
tests/runtimes/edge-runtime/package.json Version bump to 3.3.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ymc9 ymc9 added this pull request to the merge queue Feb 1, 2026
Merged via the queue into main with commit bcb323a Feb 1, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants