fix(storage): thread seed through iota fill so eval couples differ (#104)#113
Open
RealDiligent wants to merge 1 commit into
Open
fix(storage): thread seed through iota fill so eval couples differ (#104)#113RealDiligent wants to merge 1 commit into
RealDiligent wants to merge 1 commit into
Conversation
|
Gate chain passed. This PR is queued for the next batched GPU evaluation window. |
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #104:
_fill_iota()ignored theseedargument, sogenerate(..., fill="iota")always produced the same symmetric(i+j)%97pattern. The eval harness offsets seeds to build distinctA_iandB_icouples (seed+2i/seed+2i+1), but withiotathose offsets were no-ops — every couple hadA == Band all--pairswere byte-identical, silently benchmarkingA @ Ainstead of generalA @ B.Threads
seedinto_fill_iotaas(i+j+seed) % 97in bothstrategy/storage.pyandmatmul/storage.py, mirroring_fill_random/_fill_lowrank. Reopens the fix from closed PR #105 on currentmain.Result
--fill iota)Regime measured: CPU-only regression tests (
tests/test_iota_fill.py). No strategy cost claim.Raw scorecard (paste
python -m eval …output or--json)Checklist
state honestly which axis it trades — see the one rule in CONTRIBUTING.md.
This PR restores eval harness semantics for
--fill iota; not a strategy submission.python eval/tests/test_eval.py,python strategy/tests/test_subspace.py,python tests/test_correctness.py.<----ia--------e------- relabel refresh: 2026-07-07T14:23:28Z -->