docs(matmul): recompute FLOP table cells with decimal n#119
Closed
boskodev790 wants to merge 1 commit into
Closed
Conversation
…statement) fix / bug lane — docs-only, no code change. The `matmul/README.md` "it doesn't fit" table mixes unit bases: the memory columns and the 128k compute cell use decimal-k n (12000, 128000), but the 1k/16k/32k compute cells were computed with binary-k n (1024/16384/32768), overstating 2n³ by ~7% and disagreeing with the decimal memory cells in their own rows. Recomputed those three cells with decimal n to match: - 1k (n=1000): 2·1000³ = 2.0 GFLOP (was 2.1) - 16k (n=16000): 2·16000³ = 8.2 TFLOP (was 8.8) - 32k (n=32000): 2·32000³ = 66 TFLOP (was 70) 128k (4.2 PFLOP) was already decimal and is unchanged. Docs-only; touches only matmul/README.md. Fixes zeokin#102
github-actions
Bot
added
area:matmul
|
Closed as a copycat submission: 100% of added lines already appear in an earlier PR (matches an earlier PR by luciferlive112116). See .github/COPYCATS.md. |
|
copycat |
|
Closed as a copycat submission: matches an earlier PR by luciferlive112116: 100% of added lines already appear in an earlier PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lane
fix/bug— docs-only, no code change. CPU-safe.Problem
matmul/README.md's "The core problem: it doesn't fit" table mixes unit bases. The memory columns and the128kcompute cell use decimal-kn(12000, 128000), but the1k/16k/32kcells of the compute (2n³) column were computed with binary-kn(1024/16384/32768) — overstating2n³by ~7% and disagreeing with the decimal memory cells in their own rows.Fix
Recompute the three cells with the same decimal
n:128k(4.2 PFLOP) was already decimal and is unchanged. Docs-only; touches onlymatmul/README.md.Fixes #102