menuconfig: guiconfig: two minor fixes#23
Open
kartben wants to merge 2 commits intozephyrproject-rtos:mainfrom
Open
menuconfig: guiconfig: two minor fixes#23kartben wants to merge 2 commits intozephyrproject-rtos:mainfrom
kartben wants to merge 2 commits intozephyrproject-rtos:mainfrom
Conversation
kartben
changed the title
_menu_scroll is declared as global but never used in _jump_to. Removing the unnecessary declaration. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Changed orient=VERTICAL to orient="vertical". VERTICAL wasn't imported; ttk.Panedwindow expects a string. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
kartben
force-pushed
the
gui_menuconfig_minor_fixes
branch
from
d633222 to
83a4bf5
Compare
tejlmand
reviewed
Oct 28, 2025
| # and the jump-to dialog. | ||
|
|
||
| panedwindow = ttk.Panedwindow(parent, orient=VERTICAL) | ||
| panedwindow = ttk.Panedwindow(parent, orient="vertical") |
Collaborator
There was a problem hiding this comment.
VERTICAL is imported here:
Line 71 in 9b1ae78
that import provides VERTICAL.
Are you seeing any errors ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
menuconfig: _menu_scroll is declared as global but never used in _jump_to.
Removing the unnecessary declaration.
guiconfig: Changed orient=VERTICAL to orient="vertical" in ttk.Panedwindow constructor