Fix/ci format language version - #7
Merged
Merged
Conversation
dart format derives each file's language version from .dart_tool/package_config.json. Formatting without it (what the auto-format bot did) falls back to the pubspec lower bound and emits the pre-3.7 style, which CI - running after pub get - rejects. Also adds the trailing comma that flutter's analyzer wants in the runZonedGuarded callback.
The workflow ran 'dart format' on a checkout without .dart_tool/package_config.json, so the formatter used the pubspec lower bound (3.4) and committed the pre-3.7 style. CI, which installs dependencies first, expects the current style - so every bot commit kept 'Check formatting' red. Now all three packages run pub get / flutter pub get before formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.