fix #204 #205 #207#206
Open
pavel-orekhov wants to merge 11 commits into
Open
Conversation
pavel-orekhov
commented
Jan 29, 2018
pavel-orekhov
commented
- add message::operator<< for message (AKA append) and for frame
- tests for new methods
- fix indent
added 3 commits
January 29, 2018 18:07
* add message::operator<< for message (AKA append) and for frame * tests for new methods * fix indent
part 2: exception at loop.start() part 3: socket is not removed from items_ via separate cb for close() * testcases for it
pavel-orekhov
changed the title
Issue 207: stack overflow (segmentation) in loop.remove(raw_fd) in loop/raw_fd handler
bluca
reviewed
Jan 31, 2018
| void update(); | ||
| }; | ||
|
|
||
| typedef std::pair<zmq_pollitem_t, Callable> PollItemCallablePair; |
Member
There was a problem hiding this comment.
does changing these types break api backward compatibility?
Author
There was a problem hiding this comment.
I think no. it's private type. But size of class will be changed, so recompile of clients is required.
bluca, please say me what is better:
- register onAfterRemove callback at add() time
- register onAfterRemove callback at remove() time
First method is implemented now. But second seems more clean for user and more simple to implement.
bluca
reviewed
Jan 31, 2018
| * See tests/test_loop.cpp: socket_closed_in_timer and socket_closed_after_remove_at_timer | ||
| */ | ||
| void add(socket_t& socket, Callable callable, short const event = poller::poll_in); | ||
| void add(socket_t& socket, Callable callable, short const event = poller::poll_in, Callable after_remove_cb = Callable(nullptr)); |
Author
There was a problem hiding this comment.
Yes. Method's name will be mangled differently. Clients of libzmqpp need to be recompiled. But no changes at source code of clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.