Improve the checks for relative traversal.#158
Open
LQxdu wants to merge 1 commit intozeroturnaround:masterfrom
Open
Improve the checks for relative traversal.#158LQxdu wants to merge 1 commit intozeroturnaround:masterfrom
LQxdu wants to merge 1 commit intozeroturnaround:masterfrom
Conversation
Use java.nio.file.Path for consistent sub-directory checking
Collaborator
|
Currently, zt-zip is compatible with Java 6. This patch uses Java 7 API. We have to ponder whether it is time to bump the minimum Java requirement from Java 6 to Java 8. |
Author
|
Based on recent statistical research, such as reports from InfoWorld and New Relic, Java 8, 11, and 17 are the most widely used versions, while the number of users still relying on Java 6 and 7 has significantly decreased. For instance, according to the New Relic report, only 0.28% of applications are still using Java 7 in production. Therefore, I believe it is worth considering raising the minimum Java requirement from Java 6 to Java 8. |
|
Java 8 itself is long EOL but you are holding up this fix for Java 6 compatibility? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use java.nio.file.Path for consistent sub-directory checking