Open
Conversation
Collaborator
|
I'd merge this, but you need to handle errors better. If the mkdir() call fails, duc needs to error our more gracefully. I like the idea, but it needs some more work. And apologies for the delay, now that v1.5.0-rc1 is about to come out, it would be great if you could re-spin this to address these issues. |
l8gravely
added a commit
that referenced
this pull request
Jun 9, 2025
Contributor
|
Erm, 5da92b8 causes duc to fatally exit if the mkdir fails, which occurs if the directory already exists... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
~/.cachedoesn't exist, some error will happen. See termux/termux-packages#11350 (comment).