Repository navigation
Conversation
…sync load Move store.getState() after the async driver load in rehydrate() so the snapshot reflects state changes (e.g. RTK Query fulfillments) that occurred while IndexedDB was loading. Also use current reducer state instead of initial state as the merge base in REMEMBER_REHYDRATED handler.
Repository owner
deleted a comment from
codecov-commenter
Feb 18, 2026
zewish
reviewed
Feb 18, 2026
| switch (action.type) { | ||
| case REMEMBER_REHYDRATED: { | ||
| const rehydratedState = { | ||
| ...data.state, |
Owner
There was a problem hiding this comment.
I'm 99% sure this one is something we don't want to do, since it would break the loading of the initial reducer values.
Owner
|
Hey @caspg, thank you for taking the time to open a PR.
That said, I would gladly merge the |
Owner
|
Closing due to inactivity - feel free to reopen if you'd like to continue the discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an async storage driver (like IndexedDB), the
rehydratefunction callsstore.getState()before awaiting the storage load. If any actions are dispatched while the load is in-flight (e.g. RTK Query registering endpoints, middleware running), those state changes get overwritten when the rehydrated state is dispatched.There's a related issue in
rememberReducer— theREMEMBER_REHYDRATEDcase spreadsdata.state(a snapshot captured at@@INITtime) instead of the currentstateparameter.