feat(pto): implement tpush/tpop direct TPipe flow (rebased)#230
Closed
HecreReed wants to merge 8 commits intozhangstevenunity:mainfrom
Closed
feat(pto): implement tpush/tpop direct TPipe flow (rebased)#230HecreReed wants to merge 8 commits intozhangstevenunity:mainfrom
HecreReed wants to merge 8 commits intozhangstevenunity:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
|
||
| /// Find the last operation in the same block (after startOp) that reads `tile` | ||
| /// via MemoryEffectsOpInterface. | ||
| static Operation *findLastReadOf(Value tile, Operation *startOp) { |
Owner
There was a problem hiding this comment.
在 tile 被 控制流使用 或 跨 block 使用 时是不安全的？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased/forward-merged variant of #213 onto latest
main(resolves current merge conflicts) + adds a regression guard for plainpto.bind_tilelowering.Key points:
main(conflict intools/ptoas/ptoas.cppresolved while keeping A5tfreeinsertion).test/samples/BindTile/bind_tile_wrap_pointer_cast.py+ arunop.shguard so plain bind_tile never lowers toTRESHAPE(dst, src)(only SSApto.treshapeshould emitTRESHAPE).Context:
TRESHAPEsequences (Tile A; TASSIGN(A, addr); Tile B; TRESHAPE(B, A);) appear in generated C++ for non-reshape bind_tile wrappers, which can break downstream pto-isa static checks and matches v0.5 integration failures (matmul/softmax).If you prefer, we can close this PR and instead apply the small bind_tile guard commit directly onto #213 head branch.